Skip to content

Conversation

bsrecker
Copy link

The current implementation was problematic because webhook posts were not being handled in a separate thread. This PR attempts to resolve that by triggering a new thread for each post.

Additionally, the timeout duration was increased to 10 to accommodate any network issues.

@ElieTaillard
Copy link

ElieTaillard commented Nov 22, 2023

Hello @bsrecker,

I was going through the Pull Request and noticed the use of threads (threading) to handle asynchrony instead of using coroutines with the async model. I'm curious about the reasoning behind this choice, as coroutines seem to be a lighter approach in terms of resources.

Could you please explain the reasons that led to this choice rather than an approach based on coroutines? This could help in better understanding the context of the modification.

Thanks in advance for providing clarification.

@miohtama
Copy link
Contributor

Good morning all.

I just noticed this pull request one year later. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants