Wrap non-JSON responses in json error response #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisryan
approved these changes
Jan 10, 2025
Contributor
chrisryan
left a comment
chrisryan
left a comment
There was a problem hiding this comment.
Changes make sense. We should tag this as a potentially backwards breaking change. It also looks like the builds may need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request updates the GuzzleAdapter to check the HTTP response for valid JSON. Before if the response was not valid json an exception was thrown. This change will intercept the non-JSON response and return an error formatted json response containing the original non-JSON response. This will maintain the original returned API status code as well
Checklist