AGI-1181: Add Strings::stripEmoji #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbti
reviewed
Mar 10, 2025
src/Filter/Strings.php
Outdated
| * | ||
| * @return string; | ||
| */ | ||
| public static function stripEmoji(string $value, string $replacement = '') |
philbti
reviewed
Mar 10, 2025
Co-authored-by: philbti <[email protected]>
philbti
reviewed
Mar 10, 2025
philbti
reviewed
Mar 10, 2025
| */ | ||
| public static function provideStripEmoji(): array | ||
| { | ||
| return [ |
There was a problem hiding this comment.
should we do sanity checks if it strips multiple emojis properly in a message?
There was a problem hiding this comment.
yeah i can add that
Co-authored-by: philbti <[email protected]>
philbti
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request adds the
Strings::stripEmojimethod which will strip emoji characters from a given string.Checklist