Skip to content

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Aug 9, 2025

Resolves the clap deprecated api.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jplatte jplatte merged commit 7875e33 into tower-rs:main Aug 9, 2025
11 checks passed
@jplatte
Copy link
Member

jplatte commented Aug 9, 2025

By the way, if you could start your commit message (after the conventional commit prefix) with an uppercase character, that would be appreciated.

Also, this is just my personal opinion, but I think examples: is much nicer than chore(examples): . We don't use any tooling for conventional commits anyways.

@tottoto tottoto deleted the resolve-clap-deprecated-api branch August 9, 2025 10:53
@tottoto
Copy link
Contributor Author

tottoto commented Aug 9, 2025

@jplatte Understood. I would like to confirm one thing regarding the case of letters. It seems that the first letter of the commit message was not consistent in the past commit messages, so I used the style of seanmonstar, who published the most recent release. Can I assume that your instruction is the official project policy?

@jplatte
Copy link
Member

jplatte commented Aug 9, 2025

Well, I guess I am kind of the primary maintainer, so I think I can say yes ^^

However, would also like to hear @seanmonstar's opinion (I didn't notice he used a different style, to me the uppercase thing always seemed like an accepted standard amongst the vast majority of people who care about their commit message formatting).

@seanmonstar
Copy link
Collaborator

I adopted the style from some Google project a long time ago (Angular maybe?), copy-pasted a bunch of formatting rules, and saved them in repo: https://hyper.rs/contrib/commits/#subject

The norm there, and what I do, is to not capitalize the first letter in the subject. That's just how I've always done it. From my own aesthetic opinion, I think I find it a less pleasing to see some(thing): Upper. But there you go, that's my opinion. 🤷

Looking around just now, it seems that style is also used by modern tools that parse that style ("Conventional Changelog"), like git-cliff: https://github.com/orhun/git-cliff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants