Skip to content

refactor: rename generateStorage to generateLocalStorage for clarity #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: rename generateStorage to generateLocalStorage for clarity #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45efb70
refactor: rename generateStorage to generateLocalStorage for clarity
jin123457 Jun 10, 2025
6e14375
fix: rename function to match test code
jin123457 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hooks/useStorageState/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function generateTestKey() {
.join('');
}

export function generateStorage(): Storage {
export function generateLocalStorage(): Storage {
if (LocalStorage.canUse()) {
return new LocalStorage();
}
Expand All @@ -111,6 +111,6 @@ export function generateSessionStorage(): Storage {
return new MemoStorage();
}

export const safeLocalStorage = generateStorage();
export const safeLocalStorage = generateLocalStorage();

export const safeSessionStorage = generateSessionStorage();
4 changes: 2 additions & 2 deletions src/hooks/useStorageState/useStorageState.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { renderHookSSR } from '../../_internal/test-utils/renderHookSSR.tsx';

import {
generateSessionStorage,
generateStorage,
generateLocalStorage,
LocalStorage,
MemoStorage,
safeLocalStorage,
Expand Down Expand Up @@ -62,7 +62,7 @@ describe('Storage', () => {
// @ts-ignore
delete window.localStorage;

const disabledLocalStorage = generateStorage();
const disabledLocalStorage = generateLocalStorage();

expect(disabledLocalStorage).toBeInstanceOf(MemoStorage);
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Expand Down