add range validation #1887
Open
add range validation #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1887 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 13370608176Details
💛 - Coveralls |
henadzit
reviewed
Feb 18, 2025
| @@ -14,6 +14,7 @@ Changelog | |||
| Added | |||
| ^^^^^ | |||
| - Implement __contains, __contained_by, __overlap and __len for ArrayField (#1877) | |||
| - Added default range validation to IntField, BigIntField, SmallIntField | |||
There was a problem hiding this comment.
Can you please mention this PR in CHANGELOG?
| with self.assertRaises(ValidationError): | ||
| await testmodels.IntFields.create(intnum=-2147483649) | ||
|
|
||
| async def test_max(self): |
There was a problem hiding this comment.
test_max_boundary_validation is probably a better name
| with self.assertRaises(ValidationError): | ||
| await testmodels.SmallIntFields.create(smallintnum=-32769) | ||
|
|
||
| async def test_max(self): |
There was a problem hiding this comment.
test_max_boundary_validation
| with self.assertRaises(ValidationError): | ||
| await testmodels.BigIntFields.create(intnum=-9223372036854775809) | ||
|
|
||
| async def test_max(self): |
There was a problem hiding this comment.
test_max_boundary_validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please, see #1868