Minor change to TH/CMakeLists.txt #1161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, I've managed to get Torch to compile on Windows via LuaRocks and MSVC.
|
Should be noted that a custom CMake command needed to be used, in order to specify generation of NMake Makefiles. This .cmd file can be provided if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, I've managed to get Torch to compile on Windows via LuaRocks and MSVC. By configuring LuaRocks for Lua 5.3 and maintaining a directory with the corresponding Lua source and binaries, in addition to the headers and libraries for GNU Readline as a dependency for TREPL, the installation proceeds with a few equation warnings, but no compiler errors. I plan to publish a Batch file for ease of installation via command line using the MSVC tools, but in the meantime this pull is more pressing.