Extract method #1125
Open
Extract method #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been refactored by re-structuring the components of the file. The following file has been changed.
FilePath
src/main/java/amidst/mojangapi/world/icon/locationchecker/SuppressAroundLocationChecker.java
Improvements Made
The "isValidLocation()" method was previously handling multiple functionalities, which goes against the principle of single responsibility. Therefore, it has undergone a refactoring process, wherein the relevant component of the method has been extracted and implemented in a new method. This results in a more streamlined and organized code structure.
Notes for Reviewers
Thank you for taking the time to review this pull request. If you have any questions or suggestions for improvement, please don't hesitate to let me know.