-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add wallet benchmark #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/comparison.mdx |
|
waiting contribution from @pyAndr3w |
Wallet Fee Comparison ResultsRun 1: 1 messages, Body: Empty
Run 2: 4 messages, Body: Empty
Run 3: 200 messages, Body: Empty
Run 4: 1000 messages, Body: Empty
Run 5: 1 messages, Body: Comment
Run 6: 4 messages, Body: Comment
Run 7: 200 messages, Body: Comment
Run 8: 1000 messages, Body: Comment
Run 9: 1 messages, Body: Jetton
Run 10: 4 messages, Body: Jetton
Run 11: 200 messages, Body: Jetton
Run 12: 1000 messages, Body: Jetton
|
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/comparison.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. In standard/wallets/comparison.mdx, there’s one inline suggestion; please apply it.
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/comparison.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Move these comparison tables to a separate page, and disable navigation on if (see
mode: "wide"in/ecosystem/sdks, for example). Why: not enough space for tables, most columns are off the screen - Reduce column widths. For example, replace
perwith/, and(%)with%. - Numeric columns have to align to the right. https://ux.stackexchange.com/a/61051
- Set
font-variant-numeric: tabular-numsinextra.css. Docs. There is minimal profit from nicely-kerned numbers in docs, while alignment issues are a problem.
|
page is done, waiting for approval on ton-org/docs-examples#12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. In standard/wallets/performance-benchmark.mdx: one inline suggestion; please apply the inline suggestion.
Closes #656.