io: add shutdown() and shutdown_error() on tokio_test::io::Builder
#7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ADD-SP <[email protected]>
Signed-off-by: ADD-SP <[email protected]>
ADD-SP
force-pushed
the
add_sp/io-add-shutdown-mock
branch
from
4d6ae30 to
b17f254
Compare
I closed this PR. As you can see, this feature even breaks tests of the tokio itself, so it is very like a breaking change for downstream. |
ADD-SP
changed the title
shutdown() and shutdown_error() on tokio_test::io::Buildershutdown() and shutdown_error() on tokio_test::io::Builder
ADD-SP
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #7639.