style: Simplify DecodeError description to an enum #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
force-pushed
the
decode_error
branch
2 times, most recently
from
257a684 to
f30c252
Compare
LucioFranco
reviewed
Sep 19, 2025
prost/src/error.rs
Outdated
| } | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub enum DecodeErrorKind { |
There was a problem hiding this comment.
do we want this to be either non_exhaustive or pub(crate)? I don't think we want to lock ourselves in like this?
There was a problem hiding this comment.
You are right, this should be private
|
Oops, I changed the return type of a |
caspermeijn
force-pushed
the
decode_error
branch
from
f30c252 to
fd3e6dd
Compare
I reverted the return type change. I created a |
caspermeijn
force-pushed
the
decode_error
branch
from
fd3e6dd to
691b637
Compare
Replace the inner `description` field of `DecodeError` from a string to an enum. The enum implements `Display` that produces the same string.
caspermeijn
force-pushed
the
decode_error
branch
from
691b637 to
8044ea3
Compare
LucioFranco
reviewed
Oct 6, 2025
LucioFranco
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the inner
descriptionfield ofDecodeErrorfrom a string to an enum. The enum implementsDisplaythat produces the same string.Split the error for
Any::to_msgintoDecodeAnyError. This provides better separation betweenprostandprost-types.