feat: Support for marking setter and accessor methods with deprecated… #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
requested changes
Sep 19, 2025
There was a problem hiding this comment.
I recently merged #1316. Please rebase and verify this is still needed.
Please add some test that proves the deprecated attribute is actually added to the correct functions.
| attrs: &[Meta], | ||
| inferred_tag: Option<u32>, | ||
| deprecated: bool, | ||
| ) -> Result<Option<Field>, Error> { |
There was a problem hiding this comment.
This function can itself determine the deprecated state from attrs. It makes sense to do that in the for attr in attrs loop.
There was a problem hiding this comment.
In this case all non-prost attributes are filtered out by prost_attrs() before they are passed to this method. Which is why I check for the deprecated attribute before. I suppose we could adjust prost_attrs() to pass it through, though I'm not sure what other affects that might have.
What are your thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field is marked as deprecated, the setter and accessor methods should be as well.
Fixes: #985