docs: Update protobuf-src example to avoid unsafe set_var #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
approved these changes
Oct 6, 2025
caspermeijn
changed the title
|
@scintillavoy Please rebase to latest main. Some changes were made to our CI. |
auto-merge was automatically disabled
October 6, 2025 08:06
Head branch was pushed to by a user without write access
scintillavoy
force-pushed
the
update-protobuf-src-example
branch
from
b378bf8 to
a0feaf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation under "Compiling
protocfrom source" to avoid using unsafestd::env::set_var.std::env::set_varbecomes unsafe in Rust 2024 unless certain strict single-threaded conditions are met. While we could wrap the call in anunsafeblock, introducingunsafejust for setting an environment variable isn't worth the added complexity. Instead, the example now uses theprost_build::Config::protoc_executablemethod to directly set the path to theprotocbinary.