feature(prost-build): Generate less boxed if nested type is boxed manually #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldm0
force-pushed
the
boxed_break_nested
branch
from
7c5c10d to
eecd233
Compare
ldm0
force-pushed
the
boxed_break_nested
branch
from
eecd233 to
13f0b78
Compare
caspermeijn
requested changes
Oct 2, 2024
There was a problem hiding this comment.
That is an interesting problem to fix.
- Is
nestedthe correct term to use? I would use recursive, but I am not proficient in graph theory. - I would like user documentation about how this works.
- This is a breaking change, so it has to wait for the next breaking release.
| } | ||
|
|
||
| /// Check two nodes is connected with edge filter | ||
| fn is_connected_with_edge_filter<F, N, E>( |
There was a problem hiding this comment.
This is very nifty, but it is not the core strength of prost. I understand what the function is supposed to do, but I don't understand how it works. This should either be documented better or move to petgraph library.
|
|
||
| package nesting_complex; | ||
|
|
||
| // ----- Directly nested |
There was a problem hiding this comment.
I would like to have more documentation explaining how this structure is nested.
|
@ldm0 I am preparing a breaking release. Are you still interested in this? If so, please update the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1157 (comment)
This branch is based on #1157.