Skip to content

Conversation

a1phyr
Copy link

@a1phyr a1phyr commented Sep 10, 2025

  • windows-sys to 0.61 (Requires MSRV 1.71)
  • dev-dependencies: env_logger to 0.11 and rand to 0.9

It would be nice to move from the old wasi version to the new wasip1 crate but this requires MSRV 1.82, so I'm not sure this is acceptable.

@a1phyr
Copy link
Author

a1phyr commented Sep 12, 2025

Does anyone have an idea of what is causing the sanitizer error? A change in nightly maybe?

The error:

   Doc-tests mio
error: mixing `-Zsanitizer` will cause an ABI mismatch in crate `mio`
  |
  = help: the `-Zsanitizer` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely
  = note: unset `-Zsanitizer` in this crate is incompatible with `-Zsanitizer=thread` in dependency `std`
  = help: set `-Zsanitizer=thread` in this crate or unset `-Zsanitizer` in `std`
  = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=sanitizer` to silence this error

It looks like the flag isn't set properly when compiling doc-tests.

@Darksonn
Copy link
Contributor

The error is rust-lang/rust#146465.

@a1phyr
Copy link
Author

a1phyr commented Sep 23, 2025

I have added a commit to pin the nightly version until the issue is resolved.

@a1phyr
Copy link
Author

a1phyr commented Sep 25, 2025

I updated the PR to allow both 0.60 and 0.61 versions for windows-sys, so the last version can be used while not breaking MSRV.

env_logger was only updated to 0.10.

@atouchet
Copy link
Contributor

atouchet commented Oct 8, 2025

Tokio is updating their MSRV to 1.71: tokio-rs/tokio#7658. Does it make sense to do the same for Mio now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants