some new features for helpers #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1henny
commented
Feb 11, 2020
| * @param opts.baseAsset | ||
| * @param opts.quoteAssets | ||
| * @param opts.defaultQuoteAsset | ||
| * @param opts.quoteAssets |
Contributor
Author
There was a problem hiding this comment.
was duplicate at line 14
1henny
commented
Feb 11, 2020
test/scripts/create_account.js
Outdated
| } | ||
| } | ||
|
|
||
| export async function fundMasterAccount (asset, amount, assetOwner = assetHelper.masterKp) { |
Contributor
Author
There was a problem hiding this comment.
i guess there is no way to get master id in tests (except of hard coding or getting it from a helper so just in case dropped this helper here)
1henny
commented
Feb 11, 2020
| } | ||
| } | ||
|
|
||
| export async function constructPayment (fromAccount, toAccount, assetCode, amount) { |
Contributor
Author
There was a problem hiding this comment.
Tryna create configurable payment constructor here. I noticed that up to present days there were no ways to create configurable payment, only hard-coded version for tests was available
1henny
commented
Feb 11, 2020
| } | ||
| } | ||
|
|
||
| export async function createPaymentFromOpts (opts) { |
Contributor
Author
There was a problem hiding this comment.
extracting paymentHelper.create() call to use it separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.