Don't abort search, if first found key doesn't match #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could have multiple keys with the same hash sum in the CDB. So we should not abort cdb_findnext if we found the hash, but it did not matched the key to find. This regression was introduced in f20fc80.
|
I know I'm being picky, but I'd like to see a test on this. I'm concerned that not tests were changed here. Can you give me an approximate database so I can simulate the failure? |
|
The test is basically in #26 but I can try to add a test. |
|
I just added the test from the issue. The test would fail without the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could have multiple keys with the same hash sum in the CDB. So we
should not abort
cdb_findnextif we found the hash, but it did notmatched the key to find.
This regression was introduced in f20fc80.
This fixes #26.