ping.py, ping6.py, impacket-{ping, ping6}: add page #16177
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new command
spageektti
reviewed
Apr 15, 2025
spageektti
reviewed
Apr 15, 2025
Co-authored-by: Wiktor Perskawiec <[email protected]>
Co-authored-by: Wiktor Perskawiec <[email protected]>
This comment has been minimized.
This comment has been minimized.
acuteenvy
reviewed
Apr 15, 2025
Comment on lines
+4
to
+5
| > Part of the Impacket suite. | ||
| > More information: <https://github.com/fortra/impacket>. |
There was a problem hiding this comment.
"Part of the Impacket suite" doesn't add much to the description when impacket is already in the command.
More information links have been removed from alias pages (#14542), so unless the alias differs from the original command in a way that would warrant adding additional documentation, this is redundant.
Suggested change
| > Part of the Impacket suite. | |
| > More information: <https://github.com/fortra/impacket>. |
Comment on lines
+4
to
+5
| > Part of the Impacket suite. | ||
| > More information: <https://github.com/fortra/impacket>. |
There was a problem hiding this comment.
Suggested change
| > Part of the Impacket suite. | |
| > More information: <https://github.com/fortra/impacket>. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common,linux,osx,windows,sunos,android, etc.