ESP32 on Mac #11
Merged
ESP32 on Mac #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on Mac, the serial port for TBeam is same pattern as T5gray and TWrist
mixmix
approved these changes
Apr 16, 2025
loramesh/Makefile
Outdated
| @@ -151,6 +151,8 @@ ifndef SERIAL | |||
| SERIAL = $(shell ls /dev/tty.usbserial-????) | |||
| else ifeq ($(BOARD),T5gray) | |||
| SERIAL = $(shell ls /dev/tty.usbserial-???????????) | |||
| else ifeq ($(BOARD),TBeam) | |||
| SERIAL = $(shell ls /dev/tty.usbserial-???????????) | |||
loramesh/Makefile
Outdated
| endif | ||
|
|
||
| # catch all | ||
| SERIAL ?= $(shell ls /dev/tty* | grep 'ACM\|USB\|wchusb') |
There was a problem hiding this comment.
I don't know makefile, but this looks smarter than an else if it does what I think (i.e. try setting this if SERIAL was not set)
There was a problem hiding this comment.
@KevinTriplett
I think we can simplify this to just
SERIAL ?= $(shell ls /dev/tty* | grep 'ACM\|USB\|wchusb\|usbserial')
and skip the else clause. Otherwise looks good.
There was a problem hiding this comment.
I simplified it further .. see commit
|
I'm not an expert in Makefile, but this passes the "looks good" test. I'd like someone to "smoke test" this - try running this on TBeam to confirm no smoke comes out the side when you turn it on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three commits:
Commit 1 may not be acceptable, let me know if you want do this another change.
Also, I notice that recipe
flashlooks identical tofullflash-- is it vestigial and can be removed?