Skip to content

Fix workflow qr code links #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix workflow qr code links #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8176fa
chore: add apple team
timmyjose Mar 12, 2025
b776b10
chore: add text to demo screen
timmyjose Mar 12, 2025
eaf59ad
update: fix positions in workflow
timmyjose Mar 12, 2025
80bf449
fix: put the text element in the correct place
timmyjose Mar 12, 2025
792f5de
chore: fix qr code links
timmyjose Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/expo-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ jobs:
EAS_DASHBOARD_URL=$(echo "$OUTPUT" | grep -oP 'EAS Dashboard\s+\Khttps://expo.dev/accounts/[^ ]+')

# Parse the account name and project slug dynamically
ACCOUNT_NAME=$(echo "$EAS_DASHBOARD_URL" | awk -F'/' '{print $(NF-3)}')
PROJECT_SLUG=$(echo "$EAS_DASHBOARD_URL" | awk -F'/' '{print $(NF-1)}')
ACCOUNT_NAME=$(echo "$EAS_DASHBOARD_URL" | awk -F'/' '{print $(NF-4)}')
echo "ACCOUNT_NAME = ${ACCOUNT_NAME}"
PROJECT_SLUG=$(echo "$EAS_DASHBOARD_URL" | awk -F'/' '{print $(NF-2)}')
echo "PROJECT_SLUG = ${PROJECT_SLUG}"

# Fetch the correct appId using `eas project:info`
echo "Fetching EAS Project Info..."
Expand All @@ -67,7 +69,7 @@ jobs:

DEEP_LINK="exp+://expo-development-client/?url=https://u.expo.dev/$APP_ID/group/$GROUP_ID"
UPDATE_LINK="https://expo.dev/accounts/$ACCOUNT_NAME/projects/$PROJECT_SLUG/updates/$GROUP_ID"
QR_CODE_URL="https://qr.expo.dev/eas-update?slug=exp&projectId=$APP_ID&groupId=$GROUP_ID&host=u.expo.dev&scale=2"
QR_CODE_URL="https://qr.expo.dev/eas-update?slug=${PROJECT_SLUG}&projectId=$APP_ID&groupId=$GROUP_ID&host=u.expo.dev&scale=2"

echo "Deep Link: $DEEP_LINK"
echo "UPDATE_LINK=$UPDATE_LINK" >> $GITHUB_ENV
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ packages-lock.json
android
ios
.vim
link

# Expo
.expo/
Expand Down
3 changes: 2 additions & 1 deletion app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
},
"ios": {
"supportsTablet": true,
"bundleIdentifier": "com.timmyjose.expopreviewqractiondemo"
"bundleIdentifier": "com.timmyjose.expopreviewqractiondemo",
"appleTeamId": "N8XNN99644"
},
"android": {
"adaptiveIcon": {
Expand Down
1 change: 1 addition & 0 deletions src/screens/Demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const Demo = () => {

return (
<SafeAreaView style={styles.container}>
<Text>Testing</Text>
<Pressable
style={styles.button}
onPress={() => navigation.navigate('Home')}>
Expand Down