-
Notifications
You must be signed in to change notification settings - Fork 321
[Fix] Remove unsupported type params #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
WalkthroughCI Python version changed from 3.12 to 3.9; builder type-hint handling no longer reads func.type_params; dtype construction removed tvm_ffi usage and delegates to the original dtype new for string/mapped inputs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
59-62: Consider adding Python 3.9 to the test matrix for comprehensive compatibility testing.While downgrading the lint job to Python 3.9 aligns with the removal of Python 3.12.4+ specific features in
builder.py, the test matrix (line 101) still only runs on Python 3.12. This creates a gap where runtime compatibility issues with Python 3.9 may not be detected during testing, even though the code is intended to support it.Consider adding Python 3.9 to the test matrix to ensure comprehensive compatibility:
python-version: + - "3.9" - "3.12"This would provide confidence that the changes actually work on Python 3.9, not just that they pass linting and AST checks.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci.yml(1 hunks)tilelang/language/v2/builder.py(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-10T13:29:29.347Z
Learnt from: XuehaiPan
Repo: tile-ai/tilelang PR: 973
File: .github/workflows/ci.yml:13-15
Timestamp: 2025-10-10T13:29:29.347Z
Learning: In .github/workflows/ci.yml for tilelang (GitHub Actions), actions/cachev4 and setup-python’s cache feature require GITHUB_TOKEN with actions: write to save caches; with a permissions block that only sets contents: read, unspecified actions permission becomes none, so caches will restore but not save.
Applied to files:
.github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
- GitHub Check: Test for Python 3.12 with CUDA-12.8 (on self-hosted-nvidia)
🔇 Additional comments (2)
tilelang/language/v2/builder.py (2)
539-540: LGTM - Correctly removes Python 3.12.4+ dependency.The comment clearly documents why
type_paramsare not being used, and commenting out the retrieval of__type_params__(instead of deleting) preserves useful context. This change enables compatibility with Python 3.9 while maintaining the same annotation resolution behavior.
563-564: LGTM - Correctly updates_eval_typecall for Python 3.9 compatibility.The
type_paramsparameter was only added to_eval_typein Python 3.12+. The change correctly removes this parameter since the codebase does not use PEP 695 type parameters. The function will continue to resolve forward references correctly with just theglobalnsandlocalnsarguments.
This pr remove unsupported type params in
@T.prim_func. type params is support since python 3.12.4. We also downgrade the python version in CI to discover these problem more quickly in the future.Summary by CodeRabbit