Skip to content

server: Add gRPC interfaces for the new GC APIs. #9189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 92 commits into from
May 15, 2025
Merged

server: Add gRPC interfaces for the new GC APIs. #9189

merged 92 commits into from
May 15, 2025

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Apr 10, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #8978

What is changed and how does it work?

Add new gRPC API for GC as designed in the refactor task #8978 .
Also adapts the existing GC APIs to the new implementation.

Requires:

Based on #9134 . For diff between this and #9134, see: MyonKeminta/pd@m/gc-state-manager...m/new-gc-grpc-api

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@MyonKeminta
Add chagnes to the path definition
c70bd8e 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Add gc_states.go and gc_states_test.go
84b09c4 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
fix test
70c0ce9 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Add more comments
ba36b14 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
fix lint
26fc18c 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Add more comments
2622255 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Remove unnecessary commented code
db9fa7b 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Add more comments
364cf6d 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Address comments
c5653a2 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Update file headers
2f0c663 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Renaming
c1731dd 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Merge path functions
d9b944f 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
rename keypath/safe_point.go to gc_states.go
f1647bf 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Merge branch 'master' of https://github.com/tikv/pd into m/gc-state-s…
b913e1e 
…torage
@MyonKeminta
Add comments explaining keyspace-level GC and unified GC
11a002e 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Address comments
8e4bd77 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Address comments
0a5acfd 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
fix lint
42cae00 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Add related files
632a99d 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
update kvproto
66d462b 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
move code
ed770a8 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
switch implementations
d96539b 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
abandon GC API V2
1c72c88 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Address comments
397a53f 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Add test for GCBarrer.IsExpired
6445fa4 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Merge branch 'master' of https://github.com/tikv/pd into m/gc-state-s…
106639f 
…torage
@MyonKeminta
Merge branch 'm/gc-state-storage' into m/gc-state-manager
236ed1c
@MyonKeminta
Merge commit 'c1c681a' into m/gc-state-manager
11080fd
@MyonKeminta
fix lint
1530f53 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
address comments from tikv#9109
8b9c144 
Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 9, 2025
MyonKeminta added 2 commits May 9, 2025 17:21
@MyonKeminta
Fix test
90abbd8 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Fix lint
a8cd548 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta MyonKeminta force-pushed the m/new-gc-grpc-api branch from df6ac10 to a8cd548 Compare May 9, 2025 09:30
@MyonKeminta
Copy link
Contributor Author

/retest

@MyonKeminta
fix etcd key test
1b8a3f8 
Signed-off-by: MyonKeminta <[email protected]>
ystaticy
ystaticy reviewed May 12, 2025
View reviewed changes
@MyonKeminta MyonKeminta marked this pull request as ready for review May 12, 2025 09:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
@MyonKeminta
Address comments
4b14687 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Copy link
Contributor Author

/retest

JmPotato
JmPotato reviewed May 15, 2025
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@MyonKeminta
Address comments
c4b9aea 
Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2025

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label May 15, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, okJiang, ystaticy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 15, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-09 08:49:53.140001635 +0000 UTC m=+89459.287962853: ☑️ agreed by okJiang.
  • 2025-05-15 08:38:12.109715339 +0000 UTC m=+15458.365612736: ☑️ agreed by JmPotato.

@MyonKeminta
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 04f1ae0 into tikv:master May 15, 2025
26 of 36 checks passed
@MyonKeminta MyonKeminta deleted the m/new-gc-grpc-api branch May 15, 2025 08:57
@MyonKeminta MyonKeminta restored the m/new-gc-grpc-api branch May 15, 2025 08:58
@MyonKeminta MyonKeminta deleted the m/new-gc-grpc-api branch May 15, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@ystaticy ystaticy ystaticy approved these changes

@okJiang okJiang okJiang approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MyonKeminta @JmPotato @ystaticy @okJiang