Skip to content

Add sql_expr_matches method for Redshift connection. #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add sql_expr_matches method for Redshift connection. #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a02974c
Add sql_expr_matches method for Redshift connection.
krystian8207 Jun 20, 2024
0b36747
Update news.md file.
krystian8207 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: dbplyr
Title: A 'dplyr' Back End for Databases
Version: 2.5.0.9000
Version: 2.5.0.9001
Authors@R: c(
person("Hadley", "Wickham", , "[email protected]", role = c("aut", "cre")),
person("Maximilian", "Girlich", role = "aut"),
Expand Down
2 changes: 2 additions & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,8 @@ S3method(sql_expr_matches,Oracle)
S3method(sql_expr_matches,PostgreSQL)
S3method(sql_expr_matches,PostgreSQLConnection)
S3method(sql_expr_matches,PqConnection)
S3method(sql_expr_matches,Redshift)
S3method(sql_expr_matches,RedshiftConnection)
S3method(sql_expr_matches,SQLiteConnection)
S3method(sql_join,DBIConnection)
S3method(sql_join_suffix,DBIConnection)
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# dbplyr (development version)

* Redshift driver has a custom `sql_expr_matches` method, what makes
join operation statements correct when `na_matches="na"` argument is set (#1521).

* `across(everything())` doesn't select grouping columns created via `.by` in
`summarise()` (@mgirlich, #1493).

Expand Down
6 changes: 6 additions & 0 deletions R/backend-redshift.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ redshift_round <- function(x, digits = 0L) {
sql_expr(round(((!!x)) %::% float, !!digits))
}

#' @export
sql_expr_matches.RedshiftConnection <- sql_expr_matches.DBIConnection

#' @export
sql_expr_matches.Redshift <- sql_expr_matches.RedshiftConnection

#' @export
sql_translation.RedshiftConnection <- function(con) {
postgres <- sql_translation.PostgreSQL(con)
Expand Down