Skip to content

update process_.config to handle new configs from melodie change #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update process_.config to handle new configs from melodie change #242

wants to merge 1 commit into from

Conversation

EmilHvitfeldt
Copy link
Member

In reference with tidymodels/extratests#275

With the new changes in tune, the config have changed from Preprocessor1_Model04 to pre0_mod04_post0. This PR makes the changes such that the new version is similar to the old version

simonpcouch
simonpcouch reviewed Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you! I appreciate you looking into this.

What happens when folks send results resampled with a postprocessor through? I think we will end up with one more integer than stacks knows what to do with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilHvitfeldt @simonpcouch