-
Notifications
You must be signed in to change notification settings - Fork 731
Weatherbard app #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Weatherbard app #3021
Conversation
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 3 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
@mgtkach this app has an OpenWeatherMap API key stored in plain text inside the file. You should be using Pixlet's Secret Module for this. Also, I noticed that the http call to OpenWeatherMap is not using the Cache Module. If the app is installed by many users this has the potential to hit the API rate limits. |
This app takes the weather condition from openweatherapp and returns one or poetic lines that describe that condition. It will randomly choose from many.