Correct typo in 24_typical_flash_part_layout.md #26
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
reviewed
Mar 5, 2025
makubacki
approved these changes
Mar 5, 2025
bexcran
reviewed
Mar 5, 2025
| @@ -42,7 +42,7 @@ the tools for creating a compressed image and a library for decompressing the | |||
| image must be provided. These non-standard compression, encryption, signing or | |||
| verification mechanisms are applied to a GUIED encapsulation section. Each | |||
There was a problem hiding this comment.
Could you fix this at the same time please?
Similar to below, I think it should be "GUIDED".
There was a problem hiding this comment.
I'll make the change but will need confirmation regarding validity. Thank you for the suggestion.
|
Can you please add the |
makubacki
approved these changes
Mar 24, 2025
bexcran
approved these changes
Mar 24, 2025
|
I see this is targeting a release branch. This change look like it should go to the master branch first and then a different PR to apply to 1.28 branch if that is required. A change to master branch would be included in the next official release. |
Update facility -> facilitate. I believe this was the intended verbiage from the original author.
Update 24_typical_flash_part_layout.md Updated the following lines in 24_typical_flash_part_layout.md: Line 43: GUIED -> GUIDED Line 45: facility -> facilitate Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Matthew Graham <[email protected]>
mdkinney
requested review from
leiflindholm,
mdkinney and
ardbiesheuvel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 24_typical_flash_part_layout.md
Updated the following lines in 24_typical_flash_part_layout.md:
Line 43: GUIED -> GUIDED
Line 45: facility -> facilitate
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Matthew Graham [email protected]