-
Notifications
You must be signed in to change notification settings - Fork 30
Add TeamCreateAPI view #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
from django.db.models import Q, QuerySet | ||
from django.http import HttpRequest | ||
from rest_framework import serializers | ||
from rest_framework.exceptions import PermissionDenied, ValidationError | ||
from rest_framework.generics import ListAPIView, RetrieveAPIView, get_object_or_404 | ||
|
@@ -18,7 +19,7 @@ | |
CyberstormAutoSchemaMixin, | ||
conditional_swagger_auto_schema, | ||
) | ||
from thunderstore.repository.forms import AddTeamMemberForm | ||
from thunderstore.repository.forms import AddTeamMemberForm, CreateTeamForm | ||
from thunderstore.repository.models.team import Team, TeamMember | ||
|
||
|
||
|
@@ -45,6 +46,40 @@ def check_permissions(self, request: Request) -> None: | |
raise PermissionDenied() | ||
|
||
|
||
class CyberstormTeamCreateRequestSerialiazer(serializers.Serializer): | ||
name = serializers.CharField( | ||
max_length=Team._meta.get_field("name").max_length, | ||
validators=Team._meta.get_field("name").validators, | ||
) | ||
|
||
|
||
class CyberstormTeamCreateResponseSerialiazer(serializers.Serializer): | ||
name = serializers.CharField() | ||
|
||
|
||
class TeamCreateAPIView(APIView): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing permission classes (user needs to be authenticated) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All of the new views should now have |
||
@conditional_swagger_auto_schema( | ||
request_body=CyberstormTeamCreateRequestSerialiazer, | ||
responses={200: CyberstormTeamCreateResponseSerialiazer}, | ||
operation_id="cyberstorm.teams.create", | ||
tags=["cyberstorm"], | ||
) | ||
def post(self, request: HttpRequest): | ||
serializer = CyberstormTeamCreateRequestSerialiazer(data=request.data) | ||
serializer.is_valid(raise_exception=True) | ||
|
||
form = CreateTeamForm( | ||
user=request.user, | ||
data=serializer.validated_data, | ||
) | ||
|
||
if form.is_valid(): | ||
team = form.save() | ||
return Response(CyberstormTeamCreateResponseSerialiazer(team).data) | ||
else: | ||
raise ValidationError(form.errors) | ||
|
||
|
||
class TeamMemberListAPIView(CyberstormAutoSchemaMixin, TeamRestrictedAPIView): | ||
permission_classes = [AllowAny] | ||
serializer_class = CyberstormTeamMemberSerializer | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the class name:
CyberstormTeamCreateRequestSerialiazer
should beCyberstormTeamCreateRequestSerializer
. The same typo appears in the response serializer class name as well.Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.