Implement cache lock when saving files(TS-2404) #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a locking mechanism to storage.py that prevents race conditions when saving files to the mirrors. Implement tests. Refs. TS-2404
Roffenlund
force-pushed
the
storage-mirrors-bug
branch
from
91d484a to
bea7350
Compare
MythicManiac
reviewed
May 8, 2025
Comment on lines
+51
to
+63
| cache_key = f"cache_mirror_storage_{name}" | ||
|
|
||
| if not cache.add(cache_key, "LOCKED", timeout=5): | ||
| raise Exception("Another save operation is in progress for this file.") | ||
|
|
||
| try: | ||
| for storage_mirror in self.mirrors: | ||
| with TemporarySpooledCopy(content) as tmp_content: | ||
| storage_mirror.save(name, tmp_content, max_length) | ||
|
|
||
| return super().save(name, content, max_length) | ||
| finally: | ||
| cache.delete(cache_key) |
There was a problem hiding this comment.
Don't use Django cache directly, Redis has first party support for locking which should be used. Check thunderstore.cache.utils.get_cache and how it's utilized for locking in thunderstore.cache.cache.try_regenerate_cache for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a locking mechanism to storage.py that prevents race conditions when saving files to the mirrors.
Implement tests.