Add endpoint for fetching package source (TS-2282) #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roffenlund
force-pushed
the
api-endpoint-for-package-source-data
branch
from
031c313 to
fad5af9
Compare
|
|
Roffenlund
force-pushed
the
api-endpoint-for-package-source-data
branch
from
fad5af9 to
226caa2
Compare
MythicManiac
requested changes
Feb 21, 2025
django/thunderstore/api/urls.py
Outdated
| @@ -110,4 +111,4 @@ | |||
| TeamServiceAccountListAPIView.as_view(), | |||
| name="cyberstorm.team.service-account", | |||
| ), | |||
| ] | |||
| ] + plugin_registry.get_package_api_urls() | |||
There was a problem hiding this comment.
Given that we're appending these to the cyberstorm API url namespace, I feel we should make the plugin function reflect that and call it e.g. get_cyberstorm_api_urls or such. At least calling it get_package_api_urls doesn't make a lot of sense as it could actually provide any arbitrary API urls, not just package API urls
Roffenlund
force-pushed
the
api-endpoint-for-package-source-data
branch
2 times, most recently
from
9124440 to
78e8875
Compare
Add endpoint for fetching package source data. Implement tests. Refs. TS-2282
Roffenlund
force-pushed
the
api-endpoint-for-package-source-data
branch
from
78e8875 to
24c61bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an endpoint to the Cyberstorm API for fetching package source data. This endpoint returns data similarly to the
PackageSourceView.