Add CS PackageRating rate form and view #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
- Remove form usage entirely as it was complicating things for no benefit - Create a classmethod in the PackageRating model for performing the rating action (and validation of it) - Update the v1 rating API view to use the new classmethod for performing the action - Move experimental API package rating list to it's own dedicated endpoint to avoid slowing down the main current-user endpoint if there are lots of ratings - Cap the rated package count returned by the experimental API to improve performance for users with hundreds of rated packages. This should be updated to a paginated + local cache solution later on, good enough for now.
MythicManiac
force-pushed
the
cs-pkg-rate-2
branch
from
ee55dfd to
4935929
Compare
Oksamies
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1023 with the following changes:
benefit
rating action (and validation of it)
performing the action
endpoint to avoid slowing down the main current-user endpoint if there
are lots of ratings
improve performance for users with hundreds of rated packages. This
should be updated to a paginated + local cache solution later on, good
enough for now.