Implement cyberstorm view for updating teams

Implement APIView for updating teams. Currently support only
dontation_link over PATCH request.

Add URl and update tests.

Refs. TS-2314

Author: Roffenlund

django/thunderstore/api/cyberstorm/tests/test_team.py

@@ -322,3 +322,137 @@ def test_team_member_add_api_view__when_adding_a_member__fails_because_user_is_n
         .count()
         == 0
     )
+
+
+@pytest.mark.django_db
+def test_team_update_succeeds(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="owner")
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"donation_link": new_donation_link}
+    assert response.status_code == 200
+
+    assert response.json() == expected_response
+    assert Team.objects.get(pk=team.pk).donation_link == new_donation_link
+
+
+@pytest.mark.django_db
+def test_team_update_fails_user_not_authenticated(
+    api_client: APIClient,
+    team: Team,
+):
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"detail": "Authentication credentials were not provided."}
+
+    assert response.status_code == 401
+    assert response.json() == expected_response
+    assert Team.objects.get(pk=team.pk).donation_link is None
+
+
+@pytest.mark.django_db
+def test_team_update_fails_validation(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="owner")
+    api_client.force_authenticate(user)
+
+    new_bad_donation_link = "example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_bad_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"donation_link": ["Enter a valid URL."]}
+
+    assert response.status_code == 400
+    assert response.json() == expected_response
+
+
+@pytest.mark.django_db
+def test_team_update_fail_user_not_owner(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="member")
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"non_field_errors": ["Must be an owner to edit team info"]}
+
+    assert response.status_code == 403
+    assert response.json() == expected_response
+    assert Team.objects.get(pk=team.pk).donation_link is None
+
+
+@pytest.mark.django_db
+def test_team_update_fail_team_does_not_exist(
+    api_client: APIClient,
+    user: UserType,
+):
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        "/api/cyberstorm/team/FakeTeam/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"detail": "Not found."}
+
+    assert response.status_code == 404
+    assert response.json() == expected_response
+
+
+@pytest.mark.django_db
+def test_team_update_fail_user_not_team_member(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    api_client.force_authenticate(user)
+
+    new_donation_link = "https://example.com"
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": new_donation_link}),
+        content_type="application/json",
+    )
+
+    expected_response = {"non_field_errors": ["Must be a member to access team"]}
+
+    assert response.status_code == 403
+    assert response.json() == expected_response

django/thunderstore/api/cyberstorm/views/__init__.py

@@ -24,6 +24,7 @@
     TeamMemberAddAPIView,
     TeamMemberListAPIView,
     TeamServiceAccountListAPIView,
+    UpdateTeamAPIView,
 )
 
 __all__ = [
@@ -49,4 +50,5 @@
     "UpdatePackageListingCategoriesAPIView",
     "RejectPackageListingAPIView",
     "ApprovePackageListingAPIView",
+    "UpdateTeamAPIView",
 ]

django/thunderstore/api/cyberstorm/views/team.py

@@ -1,4 +1,3 @@
-from django.core.exceptions import ValidationError as DjangoValidationError
 from django.db.models import Q, QuerySet
 from rest_framework import status
 from rest_framework.exceptions import PermissionDenied, ValidationError
@@ -16,8 +15,13 @@
     CyberstormTeamAddMemberResponseSerializer,
     CyberstormTeamMemberSerializer,
     CyberstormTeamSerializer,
+    CyberstormTeamUpdateSerializer,
+)
+from thunderstore.api.cyberstorm.services.team import (
+    create_team,
+    disband_team,
+    update_team,
 )
-from thunderstore.api.cyberstorm.services import team as team_services
 from thunderstore.api.ordering import StrictOrderingFilter
 from thunderstore.api.utils import (
     CyberstormAutoSchemaMixin,
@@ -66,7 +70,7 @@ def post(self, request, *args, **kwargs):
         serializer = CyberstormCreateTeamSerializer(data=request.data)
         serializer.is_valid(raise_exception=True)
         team_name = serializer.validated_data["name"]
-        team = team_services.create_team(user=request.user, team_name=team_name)
+        team = create_team(user=request.user, team_name=team_name)
         return_data = CyberstormTeamSerializer(team).data
         return Response(return_data, status=status.HTTP_201_CREATED)
 
@@ -135,5 +139,32 @@ class DisbandTeamAPIView(APIView):
     )
     def delete(self, request, *args, **kwargs):
         team_name = kwargs["team_name"]
-        team_services.disband_team(user=request.user, team_name=team_name)
+        disband_team(user=request.user, team_name=team_name)
         return Response(status=status.HTTP_204_NO_CONTENT)
+
+
+class UpdateTeamAPIView(APIView):
+    permission_classes = [IsAuthenticated]
+    serializer_class = CyberstormTeamUpdateSerializer
+    http_method_names = ["patch"]
+
+    @conditional_swagger_auto_schema(
+        operation_id="cyberstorm.team.update",
+        tags=["cyberstorm"],
+        request_body=CyberstormTeamUpdateSerializer,
+        responses={status.HTTP_200_OK: serializer_class},
+    )
+    def patch(self, request, team_name, *args, **kwargs):
+        team = get_object_or_404(Team.objects.exclude(is_active=False), name=team_name)
+
+        serializer = self.serializer_class(data=request.data)
+        serializer.is_valid(raise_exception=True)
+
+        updated_team = update_team(
+            agent=request.user,
+            team=team,
+            donation_link=serializer.validated_data["donation_link"],
+        )
+
+        return_data = self.serializer_class(instance=updated_team).data
+        return Response(return_data, status=status.HTTP_200_OK)

django/thunderstore/api/urls.py

@@ -23,6 +23,7 @@
     TeamMemberListAPIView,
     TeamServiceAccountListAPIView,
     UpdatePackageListingCategoriesAPIView,
+    UpdateTeamAPIView,
 )
 
 cyberstorm_urls = [
@@ -126,6 +127,11 @@
         TeamAPIView.as_view(),
         name="cyberstorm.team",
     ),
+    path(
+        "team/<str:team_name>/update/",
+        UpdateTeamAPIView.as_view(),
+        name="cyberstorm.team.update",
+    ),
     path(
         "team/<str:team_name>/disband/",
         DisbandTeamAPIView.as_view(),