Skip to content

Conversation

rstms
Copy link

@rstms rstms commented Jun 2, 2025

With these fixes to the current master branch I built an XPI that seems to be working properly.

src/wx/api/sieve/SieveAccountsApi.js
API account username property changed from 'realUsername' to 'username'
API account hostname property changed from 'realHostName' to 'hostName'

src/wx/api/sieve/SieveSocketApi.js
remove ChromeUtils.import of Services.jsm
remove global comment for ChromeUtils
add global comment for Services
modify startTLS() method for changed API properties and function calls when initiating STARTTLS

src/wx/api/sieve/SieveAccountsApi.js
    API account username property changed from 'realUsername' to 'username'
    API account hostname property changed from 'realHostName' to 'hostName'

src/wx/api/sieve/SieveSocketApi.js
    remove ChromeUtils.import of Services.jsm
    remove global comment for ChromeUtils
    add global comment for Services
    modify startTLS() method for changed API properties and function calls when initiating STARTTLS
@rstms
Copy link
Author

rstms commented Jun 2, 2025

@thsmi , this PR fails to build due to eslint errors/warnings in code I didn't touch. I forked, pulled the master branch and made changes to 2 files. Should I have used a different branch as a starting point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant