Skip to content

Conversation

@0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jul 26, 2024

.ambientOcclusion also integrated into .indirect

Sequel of 9724d59

See: mrdoob/three.js#28824

`.ambientOcclusion` also integrated into `.indirect`

Sequel of 9724d59

See: mrdoob/three.js#28824
@0b5vr 0b5vr requested a review from Methuselah96 July 26, 2024 09:21
@0b5vr 0b5vr self-assigned this Jul 26, 2024
@Methuselah96
Copy link
Contributor

Are you sure? I still see ambientOcclusion right here.

@Methuselah96
Copy link
Contributor

Methuselah96 commented Jul 26, 2024

Oh, I guess it just didn't get removed from the LightingModel class, even though it doesn't get called from LightsNode anymore. Can you create a PR on three.js to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants