[WIP] Ray casting #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add basic documentation * Provide top-level documentation for every struct * Document every public entity * Replace crate-level documentation * Remove in-doc example
33: New input API r=kvark Closes #8 r? @vitvakatu
…hree-rs types. Really wanted to replace macros in `src/scene.rs` with some macros that could be used outside of the crate, but unfortunately that didn't workout because while internal three objects have access to the `node` field, structs external to the crate do not. This causes problems in `as_ref` and if that one was going to deviate, we might as well make a single macro for the special purpose of classes that wrap three-rs objects.
…work (without a lot of extra effort)
40: Added macro for implementing conversion traits on structs that wrap three-rs types. r=kvark This macro makes it really easy for structs that simply wrap a three-rs type to implement the right traits so that those custom types can interop with three-rs methods really easily. The macro is nice and flexible and the field name is optional. I chose the syntax `MyStruct#field` because it seemed more natural to me than `MyStruct.field` or `MyStruct::field` (since `x::y` is usually for modules or methods, not fields). [See the effect of this change here](https://github.com/sunjay/panda/commit/d508806d9f5f47fe4267b98f5823142108decaac) Really wanted to replace macros in `src/scene.rs` with some macros that could be used outside of the crate, but unfortunately that didn't workout because while internal three objects have access to the `node` field, structs external to the crate do not. This causes problems in `as_ref` and if that one was going to deviate, we might as well make a single macro for the special purpose of classes that wrap three-rs objects.
|
Has there been any progress on this PR? |
|
@alteous there is a lot to do here, not much progress since what is published here (distracted by other shiny things). |
|
There is now a BVH in collision-rs that has support for raycasting. It's not super fast yet, but I have some ideas for that. |
|
@Rhuagh I pushed all of the local code here now. It's hacky and not production ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23, eventually
This change is