Skip to content

Parse full line number with optional letter from skeet #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Parse full line number with optional letter from skeet #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d991999
parse full line number with optional letter from skeet
prupke2 Aug 2, 2025
ae9c561
Merge branch 'main' into parse-full-line-numbers-in-skeet
prupke2 Aug 2, 2025
695252e
clarify comment
prupke2 Aug 2, 2025
de395e5
clean up function
prupke2 Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/alerts/AlertUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const ParsedTtcAlertText = ({
const lineFilter = badge.line
? lineNum < 6
? `${lineNum}`
: `${lineNum}`
: badge.line
: badge.highlightAll
? parseLine(feedText)
: "";
Expand Down
11 changes: 10 additions & 1 deletion src/components/alerts/bsky-alerts/SkeetList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { type Skeet, SkeetElement } from "./Skeet.js";
import style from "./SkeetList.module.css";

const parseFullLineNumber = (skeet: Skeet) => {
// Match the line number as well as any possible suffix (e.g. matches "96" or "96A")
const lineTextMatch = skeet.post.record.text.match(/^\d{1,3}\S/);
return lineTextMatch?.[0] ?? null;
};

export const SkeetList = ({
skeetList,
line,
Expand All @@ -10,7 +16,10 @@ export const SkeetList = ({
line?: string;
type?: string;
}) => {
const badgeArg = line === "all" ? { highlightAll: true } : { line };
const lineNumber =
skeetList?.length > 0 ? parseFullLineNumber(skeetList?.[0]) : line;
const badgeArg =
line === "all" ? { highlightAll: true } : { line: lineNumber };
const dataArray = skeetList.map((skeet) => (
<SkeetElement key={skeet.post.cid} skeet={skeet} badge={badgeArg} />
));
Expand Down