add edge dependency types and DAGValidationError(msg) #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrings, error handling, relax tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accommodate multigraph DAG by introducing a dependency_type keyword argument on several methods. Internally, if the dependency_type is None (by default), the representation of graph edges remains the same. If the dependency_type evaluates to a boolean True, then the edge is represented as a 2-tuple (dep_node, dependency_type), and the DAG can support multiple unique edges from a node to another.
Also introduce an error message (unused, but appearing conspicuously in the stack trace), for attempts to add a cyclical edge.