(44) Rspec remediation #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General cleanup of Gemfile/Rakefile/rspec setup to current best practices Update of all files to pass tests Separate the bind::server test into bind, bind::server, and bind::service This does not guarantee 100% coverage in any way, it only ensures that existing tests pass.
anarcat
pushed a commit
to anarcat/puppet-bind
that referenced
this pull request
Nov 23, 2022
Put confdir in the params class, and more..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup of Gemfile/Rakefile/rspec setup to current best practices
Update of all files to pass tests
Separate the bind::server test into bind, bind::server, and bind::service
This does not guarantee 100% coverage in any way, it only ensures that existing tests pass.
Fixes #44