Update Snap role section in Metadata from Spec file #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
requested changes
Apr 16, 2025
content/en/docs/metadata.md
Outdated
| The snapshot role signs a metadata file that provides information about the | ||
| latest version of all targets metadata on the repository (the top-level targets | ||
| role and all delegated roles). This information allows clients to know which | ||
| metadata files have been updated and also prevents mix-and-match attacks. |
There was a problem hiding this comment.
It looks like you accidentally updated the root role section.
Also, I don't think we need to completely change the snapshot section. The original text was actually quite okay, apart from the outdated "all but timestamp.json" info.
Actually, I just saw that there's already a pending fix for this (#120). Would you mind adopting that change into your PR, including @joshuagl's suggestion, and adding the file format fix? That would be really appreciated! :)
There was a problem hiding this comment.
Wow! Silly mistake! Thanks for noticing I'll update it with @joshuagl suggestion
There was a problem hiding this comment.
Done the correction please review @lukpueh
lukpueh
approved these changes
Apr 17, 2025
This was referenced Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers issue #118. I updated the Snap role section to read like the Spec file, as suggested. Please review @lukpueh