Skip to content

Conversation

@AkshayGadhaveRH
Copy link
Contributor

@AkshayGadhaveRH AkshayGadhaveRH commented Oct 27, 2025

Since the smart proxies can be upgraded separately, some users might miss out on the information about which repos are to be synced. Adding a prerequisite to ensure this information is not skipped.

JIRA:
https://issues.redhat.com/browse/SAT-37314
Specifically this comment:
https://issues.redhat.com/browse/SAT-37314?focusedId=27987597&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27987597

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Lennonka

This comment was marked as outdated.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Oct 28, 2025
@Lennonka Lennonka changed the title Add details about repositories to Smart Proxy upgrade prereuisites Add details about repositories to Smart Proxy upgrade prerequisites Oct 28, 2025
Akshay Gadhave added 2 commits October 29, 2025 10:05
Since the smartproxies can be upgraded separately, some users might miss out on the information about which repos are to be synced.
Adding a prerequisite to ensure this information is not skipped.

JIRA:
https://issues.redhat.com/browse/SAT-37314
Specifically this comment:
https://issues.redhat.com/browse/SAT-37314?focusedId=27987597&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27987597
@AkshayGadhaveRH AkshayGadhaveRH force-pushed the add_repo-sync-prerequisite-for-capsule-upgrade branch from a2670d6 to d67ff98 Compare October 29, 2025 04:37
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 29, 2025
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

I don't think this needs tech ack nor testing.

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 29, 2025
@AkshayGadhaveRH
Copy link
Contributor Author

@Lennonka can this be merged?

@Lennonka Lennonka added the tech review done No issues from the technical perspective label Oct 30, 2025
@Lennonka Lennonka merged commit 608be5d into theforeman:master Oct 30, 2025
10 checks passed
Lennonka pushed a commit that referenced this pull request Oct 30, 2025
Add details about repositories to Smart Proxy upgrade prerequisites

Since the smartproxies can be upgraded separately, some users might miss out on the information about which repos are to be synced.
Adding a prerequisite to ensure this information is not skipped.

JIRA:
https://issues.redhat.com/browse/SAT-37314
Specifically this comment:
https://issues.redhat.com/browse/SAT-37314?focusedId=27987597&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27987597
@Lennonka
Copy link
Contributor

Cherry picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants