- 
                Notifications
    You must be signed in to change notification settings 
- Fork 106
Add details about repositories to Smart Proxy upgrade prerequisites #4428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            Lennonka
  merged 2 commits into
  theforeman:master
from
AkshayGadhaveRH:add_repo-sync-prerequisite-for-capsule-upgrade
  
      
      
   
  Oct 30, 2025 
      
    
                
     Merged
            
            Add details about repositories to Smart Proxy upgrade prerequisites #4428
                    Lennonka
  merged 2 commits into
  theforeman:master
from
AkshayGadhaveRH:add_repo-sync-prerequisite-for-capsule-upgrade
  
      
      
   
  Oct 30, 2025 
              
            
      
        
          +2
        
        
          −1
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | The PR preview for d67ff98 is available at theforeman-foreman-documentation-preview-pr-4428.surge.sh The following output files are affected by this PR: | 
Since the smartproxies can be upgraded separately, some users might miss out on the information about which repos are to be synced. Adding a prerequisite to ensure this information is not skipped. JIRA: https://issues.redhat.com/browse/SAT-37314 Specifically this comment: https://issues.redhat.com/browse/SAT-37314?focusedId=27987597&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27987597
a2670d6    to
    d67ff98      
    Compare
  
    
              
                    Lennonka
  
              
              approved these changes
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
I don't think this needs tech ack nor testing.
| @Lennonka can this be merged? | 
              
                    evgeni
  
              
              approved these changes
              
                  
                    Oct 30, 2025 
                  
              
              
            
            
    
  Lennonka 
      pushed a commit
      that referenced
      this pull request
    
      Oct 30, 2025 
    
    
      
  
    
      
    
  
Add details about repositories to Smart Proxy upgrade prerequisites Since the smartproxies can be upgraded separately, some users might miss out on the information about which repos are to be synced. Adding a prerequisite to ensure this information is not skipped. JIRA: https://issues.redhat.com/browse/SAT-37314 Specifically this comment: https://issues.redhat.com/browse/SAT-37314?focusedId=27987597&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27987597
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    style review done
  No issues from docs style/grammar perspective 
  
    tech review done
  No issues from the technical perspective 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Since the smart proxies can be upgraded separately, some users might miss out on the information about which repos are to be synced. Adding a prerequisite to ensure this information is not skipped.
JIRA:
https://issues.redhat.com/browse/SAT-37314
Specifically this comment:
https://issues.redhat.com/browse/SAT-37314?focusedId=27987597&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27987597
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: