Skip to content

Conversation

@maximiliankolb
Copy link
Contributor

What changes are you introducing?

Add a missing newline character at the end of the file.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Refs #4336

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

find guides/common/modules/ -type f -name "*.adoc" | xargs -L1 sh -c 'test "$(tail -c 1 "$0")" && echo "No new line at end of $0"'

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 20, 2025
@maximiliankolb
Copy link
Contributor Author

@jafiala I would kindly ask you to verify your editor settings as you were the last person to change this file.

@maximiliankolb maximiliankolb removed Needs tech review Requires a review from the technical perspective Not yet reviewed Needs testing Requires functional testing labels Oct 20, 2025
@github-actions
Copy link

The PR preview for 4566b83 is available at theforeman-foreman-documentation-preview-pr-4385.surge.sh

No diff compared to the current base

show diff

@maximiliankolb
Copy link
Contributor Author

@jafiala friendly reminder. Please review my PR and if possible check your editor settings. Your can use the command from the description to verify this.

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Oct 28, 2025
@maximiliankolb maximiliankolb merged commit 837ed63 into theforeman:master Oct 29, 2025
10 of 11 checks passed
@maximiliankolb maximiliankolb deleted the fix_file_ending branch October 29, 2025 07:10
maximiliankolb added a commit that referenced this pull request Oct 29, 2025
@maximiliankolb
Copy link
Contributor Author

Merged to "master" and cherry-picked:
4a8e55a..516f95d 3.16 -> 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants