Skip to content

Conversation

@maximiliankolb
Copy link
Contributor

What changes are you introducing?

  • Do not overwrite context for bootdisk provisioning
  • Remove unused attribute

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Simplify maintenance

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 13, 2025
@maximiliankolb maximiliankolb removed Needs tech review Requires a review from the technical perspective Not yet reviewed Needs testing Requires functional testing labels Oct 13, 2025
@maximiliankolb
Copy link
Contributor Author

follow-up task: Remove _{context} in guides/common/modules/proc_deploying-ssh-keys-during-provisioning.adoc:

$ rg -i "Deploying_SSH_Keys_During_Provisioning"
guides/common/modules/proc_deploying-ssh-keys-during-provisioning.adoc
3:[id="Deploying_SSH_Keys_During_Provisioning_{context}"]

guides/common/modules/con_managing-ssh-keys.adoc
7:For information on deploying SSH keys during provisioning, see {ProvisioningDocURL}Deploying_SSH_Keys_During_Provisioning_provisioning[Deploying SSH Keys during Provisioning] in _{ [... 0 more matches]

include::modules/proc_generating-a-host-boot-disk.adoc[leveloffset=+1]
endif::[]

include::modules/proc_deploying-ssh-keys-during-provisioning.adoc[leveloffset=+1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI If you remove the context from the ID of this module, there's gonna be a problem because this module is currently included in both network boot and boot disk assemblies.


:using-bootdisks-to-provision-hosts:
:parent-context: {context}
:context: using-bootdisks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This context is currently in use in a module in this assembly.

@Lennonka
Copy link
Contributor

For the reasons above, I advise against this change at the present time.

There are further improvements planned for the Provisioning guide. Perhaps de-duplicating usage of the aforementioned module could be part of them. (Let's file a new issue?) cc @jafiala

Afterwards we can consider removing the child context in these assemblies.

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Oct 16, 2025
@maximiliankolb maximiliankolb marked this pull request as draft October 17, 2025 06:15
@maximiliankolb
Copy link
Contributor Author

Thanks Lena, I agree that we need to fix the other "issue" first. -> Converted to draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Waiting on contributor Requires an action from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants