-
Couldn't load subscription status.
- Fork 106
Remove context bootdisk provisioning #4347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove context bootdisk provisioning #4347
Conversation
|
The PR preview for a5fa0fe is available at theforeman-foreman-documentation-preview-pr-4347.surge.sh The following output files are affected by this PR: |
|
follow-up task: Remove |
| include::modules/proc_generating-a-host-boot-disk.adoc[leveloffset=+1] | ||
| endif::[] | ||
|
|
||
| include::modules/proc_deploying-ssh-keys-during-provisioning.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI If you remove the context from the ID of this module, there's gonna be a problem because this module is currently included in both network boot and boot disk assemblies.
|
|
||
| :using-bootdisks-to-provision-hosts: | ||
| :parent-context: {context} | ||
| :context: using-bootdisks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This context is currently in use in a module in this assembly.
|
For the reasons above, I advise against this change at the present time. There are further improvements planned for the Provisioning guide. Perhaps de-duplicating usage of the aforementioned module could be part of them. (Let's file a new issue?) cc @jafiala Afterwards we can consider removing the child context in these assemblies. |
|
Thanks Lena, I agree that we need to fix the other "issue" first. -> Converted to draft for now. |
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Simplify maintenance
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: