Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Conversation

@bhargavraviya
Copy link

Convert according Laravel 11 routes files

  • Change routes class for future Laravel 11
  • Change to class
  • adding facades in routes files

#5846

@soinalastudio

@tnylea and @emptynick

@jonathanribas

Copy link

@soinalastudio soinalastudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, Ok

@bobbyiliev
Copy link
Contributor

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

@bhargavraviya bhargavraviya changed the base branch from 1.6 to 1.8 September 23, 2024 13:35
@bhargavraviya
Copy link
Author

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

change to PR for 1.8 version please check and merge it

@bobbyiliev

Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

change to PR for 1.8 version please check and merge it

@bobbyiliev

Thanks!

Can you rebase the PR? Want to make sure that the tests are passing.

@bhargavraviya
Copy link
Author

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

change to PR for 1.8 version please check and merge it
@bobbyiliev

Thanks!

Can you rebase the PR? Want to make sure that the tests are passing.

yes please check it proper

@bobbyiliev
Copy link
Contributor

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

change to PR for 1.8 version please check and merge it
@bobbyiliev

Thanks!
Can you rebase the PR? Want to make sure that the tests are passing.

yes please check it proper

Did you rebase it? Doesn't look like you did.

@bhargavraviya
Copy link
Author

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

change to PR for 1.8 version please check and merge it
@bobbyiliev

Thanks!
Can you rebase the PR? Want to make sure that the tests are passing.

yes please check it proper

Did you rebase it? Doesn't look like you did.

it already rebase please check it and if any issue then please guide me

@bobbyiliev
Copy link
Contributor

No need to merge this PR to the 1.6 branch. We will leave the 1.6 branch as a stable version for Laravel 9. The 1.7 for Laravel 10 and the 1.8 branch for Laravel 11.

change to PR for 1.8 version please check and merge it
@bobbyiliev

Thanks!
Can you rebase the PR? Want to make sure that the tests are passing.

yes please check it proper

Did you rebase it? Doesn't look like you did.

it already rebase please check it and if any issue then please guide me

Thanks, I can see that you rebased it yesterday.

Tests seem to be failing, so we can't go ahead and merge it until tests pass.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants