Skip to content

fix: Fix undefined Node error (nodejs) #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix: Fix undefined Node error (nodejs) #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions src/to-appear-before.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
import {checkHtmlElement} from './utils'

// ref: https://dom.spec.whatwg.org/#dom-node-document_position_disconnected
const DOCUMENT_POSITION_DISCONNECTED = 0x01
const DOCUMENT_POSITION_PRECEDING = 0x02
const DOCUMENT_POSITION_FOLLOWING = 0x04
const DOCUMENT_POSITION_CONTAINS = 0x08
const DOCUMENT_POSITION_CONTAINED_BY = 0x10
const DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 0x20

// ref: https://developer.mozilla.org/en-US/docs/Web/API/Node/compareDocumentPosition
const DOCUMENT_POSITIONS_STRINGS = {
[Node.DOCUMENT_POSITION_DISCONNECTED]: 'Node.DOCUMENT_POSITION_DISCONNECTED',
[Node.DOCUMENT_POSITION_PRECEDING]: 'Node.DOCUMENT_POSITION_PRECEDING',
[Node.DOCUMENT_POSITION_FOLLOWING]: 'Node.DOCUMENT_POSITION_FOLLOWING',
[Node.DOCUMENT_POSITION_CONTAINS]: 'Node.DOCUMENT_POSITION_CONTAINS',
[Node.DOCUMENT_POSITION_CONTAINED_BY]: 'Node.DOCUMENT_POSITION_CONTAINED_BY',
[Node.DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC]:
[DOCUMENT_POSITION_DISCONNECTED]: 'Node.DOCUMENT_POSITION_DISCONNECTED',
[DOCUMENT_POSITION_PRECEDING]: 'Node.DOCUMENT_POSITION_PRECEDING',
[DOCUMENT_POSITION_FOLLOWING]: 'Node.DOCUMENT_POSITION_FOLLOWING',
[DOCUMENT_POSITION_CONTAINS]: 'Node.DOCUMENT_POSITION_CONTAINS',
[DOCUMENT_POSITION_CONTAINED_BY]: 'Node.DOCUMENT_POSITION_CONTAINED_BY',
[DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC]:
'Node.DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC',
}

Expand Down Expand Up @@ -46,14 +54,14 @@ function checkToAppear(methodName, targetDocumentPosition) {
}

export function toAppearBefore(element, secondElement) {
return checkToAppear(
'toAppearBefore',
Node.DOCUMENT_POSITION_FOLLOWING,
).apply(this, [element, secondElement])
return checkToAppear('toAppearBefore', DOCUMENT_POSITION_FOLLOWING).apply(
this,
[element, secondElement],
)
}

export function toAppearAfter(element, secondElement) {
return checkToAppear('toAppearAfter', Node.DOCUMENT_POSITION_PRECEDING).apply(
return checkToAppear('toAppearAfter', DOCUMENT_POSITION_PRECEDING).apply(
this,
[element, secondElement],
)
Expand Down
4 changes: 2 additions & 2 deletions tests/jest.config.dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ const path = require('path')
const config = require('kcd-scripts/jest')

module.exports = {
...config,
rootDir: path.resolve(__dirname, '..'),
displayName: 'jsdom',
testEnvironment: 'dom',
...config,
testEnvironment: 'jsdom',
}
2 changes: 1 addition & 1 deletion tests/jest.config.node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ const path = require('path')
const config = require('kcd-scripts/jest')

module.exports = {
...config,
rootDir: path.resolve(__dirname, '..'),
displayName: 'node',
testEnvironment: 'node',
...config,
}