[pull] master from robotframework:master #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://master-n02a3.squash.io |
Avoid conflict with Python's standard exception with the same name. Related to #5377.
This is related to #5393. Problems were discovered when unit tests didn't succeed on Python 3.8. Investigation reveladed this: 1. Python 3.8 doesn't have Annotated that was used in a test that validated the fix for #5393. 2. Annotated can be imported from typing_extensions in tests, but it turned out that Python 3.8 get_origin and get_args don't handle it properly so test continued to fail. 3. A fix for the above was trying to import also get_origin and get_args from typing_extensions on Python 3.8. That fixed the provious problem, but string representation was still off. 4. It turned out that our type_name and type_repr didn't handle Annotated and TypeRef properly. Most likely the same issue occurred also with other parameterized special forms.
Don't remove existing SUITE scope variables with same name. Fixes #5399.
`Process.run_process` signature will change as part of #5412. Better to use a custom library in Libdoc tests instead.
See issue #3278. User Guide documentation still missing and some cleanup to be done.
- Enhance error reporting with embedded args having invalid type. - Consistent test case naming style. - Some code cleanup. Part of #3278.
Consistently use `${tc[0, 1]}` style for accessing keywords, messages,
etc. Avoid `${tc.body[0]}` and `${tc.body[0][1]}`.
Use `xml.etree.ElementTree` instead.
Replace their usages with isinstance. Also remove is_truthy usages that are already handled by automatic argument conversion. Fixes #5416.
One less thing for linters to complain.
It probably was useful when we supported Jython, but it's not useful anymore.
Previous messages weren't restored meaning that messages could be lost. The unused variable also made linters unhappy. This code attemps to avoid problems with timeouts interrupting writing to output files. The current code was written to fix #5395 and is basically a rewrite of the fix for #2839. As #5417 explains, there are still problems and bigger changes are needed.
This is a huge commit containing following changes: - Code formatting with Black. This includes changing quote styles from single quotes to double quotes. - Linting with Ruff and fixing found issues. - Import sorting and cleanup with Ruff. - Reorganization of multiline imports with isort. Imports that are part of public APIs are excluded. - Manual inspection of all changes. Includes refactoring to make formatting better and some usages of `# fmt: skip`. - Converting string formatting to use f-strings consistently. - Configuration for Black, Ruff and isort in `pyproject.toml`. - Invoke task `invoke format` for running the whole formatting process. This formatting is done only for `src`, `atest` and `utest` directories, but the task allows formatting also other files.
These keywords got the Secret support: - Create File - Append to File - Set Environment Variable - Append to Environment Variable Part of #5512.
Earlier both `str()` and `repr()` returned `Secret(value=<secret>)`, now that's only used by `repr()`. Also enhance tests to actually validate logged value. Little cleanup to tests as well. This is an enhancement to #4537.
Fixes subtle problems with using ListConverter for handling Sequence and DictionaryConverter for handling Mapping. Fixes #5531.
- Change ListConverter to extend SequenceConverter and DictionaryConverter to extend MappingConverter to remove uplication. - Utilize new `_string_convert` hook method in cases where the existing `_non_string_conver` was used to make the converted type more explicit. Related to changes done as part of #5531.
Also change Python 3.14 to release version.
Related to PR #5524.
Part of #5373. Also some other changes: - Documentation enhancement. Mostly removing information that's now got automatically based on type hints. - Don't support using an empty string for disabling timeouts. This wasn't documented anywhere and preserving the functionality would have required using `timedelta | Literal[""] | None` instead of `timedelta | None`. Documented ways to disable timeout continue to work. - Use NamedTemporaryFile, not TemporaryFile, with stdin content to get sane file name shown in configuration.
Part of #5373.
Part of #5373.
This seems to be the recommended naming style for type aliases. Old name is preserved for backwards compatibility reasons for now.
Make it more explicit that `Run`, `Run And Return RC` and `Run And Returcn RC And Output` are considered deprecated and the Process library should be used instead. Especially `Run` is so widely used that we cannot remove or even loudly deprecate it yet. Fixes #5535.
It seemed to be impossible the get the granurality needed for whitespaces with tempaltes, fallback to render with TS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )