Skip to content

Conversation

sdobbert
Copy link
Contributor

Description

This adds Unittest for some components where they were previously missing.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm run check locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@sdobbert sdobbert marked this pull request as ready for review September 30, 2025 15:17
@sdobbert sdobbert mentioned this pull request Oct 1, 2025
15 tasks
@marcjansen
Copy link
Member

marcjansen commented Oct 1, 2025

This looks great. Please merge, and then try to pick additional tests (if any) from #4394

That also has some changes to components, so I think there is some value in the other PR.

Please go ahead and pick whatever you think is good from my PR.

@marcjansen marcjansen merged commit 913d1d0 into main Oct 2, 2025
2 checks passed
@marcjansen marcjansen deleted the add-unittests branch October 2, 2025 06:18
@sdobbert sdobbert mentioned this pull request Oct 2, 2025
15 tasks
@dnlkoch
Copy link
Member

dnlkoch commented Oct 9, 2025

🎉 This PR is included in version 32.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants