fix(StringUtil): make stringDivider function cut at actual given length #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonseyock
force-pushed
the
fix-string-divider
branch
from
9dcfb6e to
bf22eb4
Compare
marcjansen
approved these changes
Oct 2, 2025
|
Yes, we can make it a breaking change. |
BREAKING CHANGE: The stringDivider function now breaks at given length and not at given length + 1.
simonseyock
force-pushed
the
fix-string-divider
branch
from
c6833b6 to
c9de802
Compare
dnlkoch
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stringDivider function was not splitting at width, but at width+1. Thanks to @marcjansen for mentioning this in terrestris/react-geo#4394.