OCM-18657 | feat: Add external auth provider resource with validation #983
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gdbranco
force-pushed
the
feat/ocm-18657
branch
from
c407de4 to
c5d1c1e
Compare
- Add comprehensive external auth provider resource structure - Implement schema with full validation including HTTPS URLs, client secrets - Add custom validation for client ID/secret combinations - Create complete state structures following backend API model - Add subsystem tests for validation scenarios - Register resource in provider - Implement placeholder CRUD operations (to be completed in OCM-18658)
… import, registration and comprehensive testing
Complete external auth provider implementation with import, registration and comprehensive testing
Implements OCM-18658, OCM-18659, OCM-18660, and OCM-18661:
**CRUD operations (OCM-18658):**
* Implement create, update and delete operations for
external_auth_provider resource
**Import Functionality (OCM-18659):**
* Implement import format: cluster_id,provider_id
* Add comprehensive import validation and error handling
* Support importing existing external auth providers into Terraform state
**Resource Registration (OCM-18660):**
* Register rhcs_external_auth_provider resource in provider schema
* Add resource to provider.go with external_auth_provider.New()
* Enable resource discovery and usage in Terraform configurations
**Comprehensive Testing (OCM-18661):**
* Add comprehensive subsystem tests covering resource lifecycle
* Implement proper OCM API mocking with cmv1.MarshalCluster() and RespondWithJSON()
* Add CRUD operation tests (Create, Read, Update, Delete) with terraform apply
* Include static validation, runtime validation, and import functionality tests
* Add console client configuration testing with proper array schema
**Test Coverage Includes:**
- Static validation (schema, field requirements, HTTPS validation)
- Runtime validation (cluster checks, external auth enablement)
- Import functionality (format validation, provider retrieval)
- Full CRUD operations (Create, Read, Update, Delete with terraform apply)
- Edge cases and error scenarios
- Console client array configuration testing
gdbranco
force-pushed
the
feat/ocm-18657
branch
from
d011829 to
944589e
Compare
|
@gdbranco: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):Fixes #OCM-18657
Change type
Checklist