add examples of byoc, private link and multi az #29
Conversation
|
@arendej @bardielle Please review. |
| resource "ocm_cluster_wait" "rosa_cluster" { | ||
|  cluster = ocm_cluster.rosa_cluster.id | ||
| timeout = 30 | ||
| } |
There was a problem hiding this comment.
@bardielle can you elaborate?
There was a problem hiding this comment.
In your lase commit you added the line 181 and 183 with a sign that looks different: 
 cluster = ocm_cluster.rosa_cluster.id
timeout = 30
}
There was a problem hiding this comment.
hmm. I do not see that in either diff/file difference on github 🤔
| To deploy ROSA to an existing VPC, the end user needs to provide subnet ids by editing aws_subnet_ids attribute. | ||
|
|
||
| ``` | ||
| resource "ocm_cluster_rosa_classic" "rosa_sts_cluster" { |
There was a problem hiding this comment.
maybe we need to supply the tf files for creating a VPC? or adding prerequisites?
|
|
||
| ### Bring your own VPC | ||
|
|
||
| To deploy ROSA to an existing VPC, the end user needs to provide subnet ids by editing aws_subnet_ids attribute. |
There was a problem hiding this comment.
please fix the commit message (byoc-> byo VPC)
| } | ||
| ``` | ||
|
|
||
| ## Advanced Usages |
There was a problem hiding this comment.
Please do not edit the index.md manually - I tried to talk about it in the last sync meeting, after running make generate, the generate tool replaced that file with an auto-generated...
we need to find a different way to edit that file
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@datianshi can we close that PR? |
|
/retest |
|
@datianshi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.