Do not merge: testing bad update

[daniel-butler-irl]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[daniel-butler-irl]

🤖 Bob Reviewer - Automated Code Review

Summary

Analyzed 2 files with 4 lines changed (2 additions, 2 deletions).

Findings Overview

• Total Issues Found: 2
• Blocking: 2 ❌
• Warnings: 0
• Suggestions: 0

Issues by Category

• Naming Conventions: 2 blocking issues
• Security: 0 issues
• Best Practices: 0 issues
• Style: 0 issues

---

🚨 Critical Issues Found

1. [Naming - BLOCKING] Inconsistent Variable Naming in variables.tf

File: variables.tf (Line 5)
Change: resource_group_id → resource_gRoup_id

Issue:
The variable name has been changed with inconsistent casing (capital 'R' in the middle of the word), violating Terraform naming conventions.

Why this matters:

• ❌ Violates Terraform naming conventions which require snake_case with lowercase letters
• ❌ This is a breaking change that will break all existing code using this module
• ❌ Inconsistent naming reduces code readability and maintainability
• ❌ Will cause issues with variable references throughout the codebase

Recommendation:

# ❌ Current (incorrect)
variable "resource_gRoup_id" {

# ✅ Should be (correct)
variable "resource_group_id" {

Revert this change and keep the original variable name resource_group_id. Variable names should use consistent snake_case formatting with all lowercase letters.

Reference: TERRAFORM.md Section 2 - "Use consistent naming conventions"

---

2. [Documentation - BLOCKING] README Documentation Inconsistency

File: README.md (Line 192)
Change: Documentation updated to reflect incorrect variable name

Issue:
The README has been updated to document the incorrect variable name resource_gRoup_id instead of the correct resource_group_id.

Why this matters:

• ❌ Documentation should reflect correct, standards-compliant code
• ❌ This propagates the naming convention violation
• ❌ Users following the documentation will use incorrect variable names
• ❌ Creates confusion and technical debt

Recommendation:

# ❌ Current (incorrect)
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) |

# ✅ Should be (correct)
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) |

Revert this documentation change. The README should document the correct variable name resource_group_id following Terraform naming conventions.

Reference: MARKDOWN.md Section 6 - "Keep documentation up-to-date" and "Documentation matches current code behavior"

---

📋 Top Recommendations

1. 🔴 Revert the variable name change - The change from resource_group_id to resource_gRoup_id violates Terraform naming standards and is a breaking change
2. 🔴 Revert the README documentation - Documentation should reflect correct naming conventions
3. ⚠️ Review PR title - The PR is marked "Do not merge: testing bad update" which suggests this may be intentional test data

---

📊 Overall Assessment

❌ CHANGES REQUESTED - Cannot be merged in current state

The changes introduce naming convention violations that break Terraform best practices and would be breaking changes for existing users of this module. Both the code and documentation changes must be reverted before this PR can be approved.

Files Analyzed

• ✅ variables.tf - 1 blocking issue found
• ✅ README.md - 1 blocking issue found

Review Status

• Blocking Issues: 2
• Action Required: Revert both changes
• Estimated Fix Time: < 5 minutes

---

🤖 Review performed by Bob Reviewer - Automated Infrastructure Code Review Assistant
Review completed at: 2025-11-17T14:08:29Z

[daniel-butler-irl]

🤖 Bob Reviewer - Automated Code Review

Review Status: ❌ CRITICAL ISSUES FOUND

I've completed an automated review of PR #1008 and identified critical blocking issues that must be addressed.

---

📊 Review Summary

Files Analyzed

• ✅ variables.tf (1 addition, 1 deletion)
• ✅ README.md (1 addition, 1 deletion)

Issues Breakdown

• 🔴 Blocking Issues: 2
• ⚠️ Warnings: 1
• 💡 Suggestions: 0

---

🔴 Critical Issues (Must Fix)

1. [Naming - Blocking] Variable Name Violates Terraform Naming Conventions

File: variables.tf (line 5)

Issue:
The variable name resource_gRoup_id violates Terraform naming conventions by using mixed case (capital 'R' in the middle).

• ❌ Terraform variables should use snake_case (all lowercase with underscores)
• ❌ The name resource_gRoup_id is inconsistent with standard practices
• ❌ This violates repository naming consistency guidelines

Why it matters:

• Breaks Terraform community standards
• Inconsistent with all other variables in the repository
• Confusing for users and maintainers

Recommendation:

variable "resource_group_id" {
  type        = string
  description = "The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`."
  default     = null

Reference: TERRAFORM.md - Section 4 (Variable Management)

---

2. [Security - Blocking] Broken Validation Logic

File: variables.tf (line 10)

Issue:
The validation condition references var.resource_group_id, but the variable is now named var.resource_gRoup_id. This creates a critical error.

variable "resource_gRoup_id" {
  # ...
  validation {
    condition     = var.create_cos_instance == false || var.resource_group_id != null
    #                                                    ^^^^^^^^^^^^^^^^^^^^^^^^
    #                                                    ERROR: References wrong variable name!
    error_message = "If `var.create_cos_instance` is `true`, then provide a value for `var.resource_group_id` to create an Object Storage instance."
  }
}

Impact:

• 💥 Terraform will fail during validation
• 💥 Module cannot be initialized or used
• 💥 This is a critical functional error that breaks the module

Recommendation:
Revert the variable name to resource_group_id to fix the validation logic.

---

⚠️ Warnings

3. [Documentation - Warning] README Contains Incorrect Variable Name

File: README.md (line 192)

Issue:
The README documents the variable with incorrect casing resource_gRoup_id, which:

• Confuses users about proper variable naming
• Is inconsistent with Terraform best practices
• Misleads users in the documentation

Recommendation:

| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

---

🔍 Change Impact Analysis

Breaking Change Detected

This change renames a core variable from resource_group_id to resource_gRoup_id, which is a BREAKING CHANGE that affects:

Impacted Areas:

• ❌ All existing users of this module must update their configurations
• ❌ All example configurations need updates
• ❌ All test files need updates
• ❌ All dependent modules need updates

Missing Required Actions:

• CHANGELOG entry with "BREAKING CHANGE" label
• Migration guide explaining the change
• Major version bump (following semver)
• Update all examples to use new variable name
• Update all tests to use new variable name
• Update all module consumers

Reference: CHANGE-IMPACT.md - Breaking Changes Section

---

📋 Repository-Wide Context Issues

Missing Updates Based on Context-Aware Review

1. Test Coverage (TEST-COVERAGE.md)

• ⚠️ No test updates to validate the variable name change
• ⚠️ Tests likely still reference resource_group_id
• ⚠️ This will cause test failures in CI/CD

2. Consistency (REPOSITORY-CONSISTENCY.md)

• ⚠️ Variable naming is now inconsistent with Terraform standards
• ⚠️ Breaks the snake_case convention used throughout the repository
• ⚠️ All other variables use lowercase with underscores

3. Documentation (DOCUMENTATION-CONTEXT.md)

• ⚠️ No CHANGELOG entry for this breaking change
• ⚠️ No migration guide provided
• ⚠️ Examples not updated to reflect change

---

💡 Recommendations

Immediate Actions Required

Option 1: Revert the Change (Recommended)

1. ✅ Revert variable name to resource_group_id
   • Maintains consistency with Terraform naming conventions
   • Avoids introducing a breaking change
   • Fixes the validation logic error
   • No migration needed

Option 2: If Change is Intentional

1. ❌ Provide clear justification for non-standard naming
2. ❌ Fix validation condition to reference correct variable name
3. ❌ Update CHANGELOG with BREAKING CHANGE notice
4. ❌ Provide comprehensive migration guide
5. ❌ Update all examples and tests
6. ❌ Bump major version (e.g., 1.x.x → 2.0.0)
7. ❌ Update all dependent modules

---

📝 Additional Notes

The PR title "Do not merge: testing bad update" suggests this is a test PR. If this is intentional for testing purposes:

• ✅ The test successfully demonstrates how naming violations are caught
• ✅ The test shows how validation logic can break
• ⚠️ Ensure this PR is not accidentally merged
• 💡 Consider using a draft PR for testing purposes

---

🎯 Review Conclusion

Overall Assessment: ❌ CHANGES REQUIRED

This PR introduces critical issues that will break module functionality:

1. 🔴 Naming convention violation (Blocking)
2. 🔴 Broken validation logic (Blocking)
3. ⚠️ Undocumented breaking change (Warning)

Recommendation: Revert the variable name change to resource_group_id to maintain consistency and functionality.

---

📚 References

• TERRAFORM.md - Variable Management Best Practices
• REPOSITORY-CONSISTENCY.md - Naming Consistency
• CHANGE-IMPACT.md - Breaking Changes
• DOCUMENTATION-CONTEXT.md - Required Documentation Updates

---

This is an automated review by Bob Reviewer. For questions or feedback, please contact the maintainers.

[daniel-butler-irl]

🤖 Bob Reviewer - Automated Code Review

Summary

Status: ❌ BLOCKING ISSUES FOUND - Changes should not be merged

Files Analyzed: 2

• README.md (1 addition, 1 deletion)
• variables.tf (1 addition, 1 deletion)

---

📊 Findings Overview

Category	Blocking	Warning	Suggestion	Total
Naming	1	0	0	1
Consistency	1	0	0	1
Change Impact	1	0	0	1
Validation	1	0	0	1
Total	4	0	0	4

---

🚨 Critical Issues (Must Fix Before Merge)

1. [Naming - Blocking] Invalid Variable Name Casing

File: variables.tf (line 5)
File: README.md (line 192)

The variable name resource_gRoup_id violates Terraform naming conventions. Variable names must use snake_case (all lowercase with underscores), not mixed case.

Current (Incorrect):

variable "resource_gRoup_id" {
  type        = string
  description = "The resource group ID for the Object Storage instance..."

Expected (Correct):

variable "resource_group_id" {
  type        = string
  description = "The resource group ID for the Object Storage instance..."

Impact:

• ❌ Violates Terraform style guide and best practices
• ❌ Inconsistent with all other variables in the codebase
• ❌ Makes code harder to read and maintain
• ❌ Non-standard naming that will confuse users

Reference: TERRAFORM.md - Section 4 (Variable Management)

---

2. [Consistency - Blocking] Variable Name Inconsistency

Files: variables.tf, README.md

The variable name change from resource_group_id to resource_gRoup_id creates inconsistency with:

• ✗ All other variables in this module (which use snake_case)
• ✗ IBM Cloud Terraform provider conventions
• ✗ Other IBM Cloud Terraform modules in terraform-ibm-modules organization
• ✗ Standard Terraform practices

Impact:

• Breaks repository-wide naming consistency
• Violates established patterns across the terraform-ibm-modules organization
• Creates confusion for module users

Reference: REPOSITORY-CONSISTENCY.md - Section 1 (Naming Consistency)

---

3. [Change Impact - Blocking] Breaking Change Without Documentation

Files: variables.tf, README.md

Renaming a variable from resource_group_id to resource_gRoup_id is a BREAKING CHANGE that requires:

• ❌ CHANGELOG entry with "BREAKING CHANGE" label - MISSING
• ❌ Migration guide explaining the change - MISSING
• ❌ Major version bump (e.g., 8.x.x → 9.0.0) - MISSING
• ❌ All examples updated - NOT VERIFIED
• ❌ All tests updated - NOT VERIFIED

Impact:

• 💥 All existing users of this module will experience failures
• 💥 Configurations referencing var.resource_group_id will break
• 💥 No migration path provided for users
• 💥 Violates semantic versioning principles

What's Required for Breaking Changes:

1. Update CHANGELOG.md with "BREAKING CHANGE" section
2. Create migration guide (MIGRATION.md or in README)
3. Bump major version number
4. Update all examples in examples/ directory
5. Update all tests in tests/ directory
6. Update all documentation

Reference: CHANGE-IMPACT.md - Section "Breaking Changes Detection"

---

4. [Validation - Blocking] Broken Variable Validation

File: variables.tf (line 10)

The validation rule still references var.resource_group_id but the variable is now named var.resource_gRoup_id. This creates a Terraform validation error.

Current Code (Broken):

variable "resource_gRoup_id" {
  type        = string
  description = "The resource group ID for the Object Storage instance..."
  default     = null
  validation {
    condition     = var.create_cos_instance == false || var.resource_group_id != null
    #                                                    ^^^^^^^^^^^^^^^^^^^^^^^^
    #                                                    References wrong variable name!
    error_message = "If `var.create_cos_instance` is `true`, then provide a value for `var.resource_group_id` to create an Object Storage instance."
  }
}

Impact:

• 🔴 terraform validate will fail
• 🔴 Module cannot be used
• 🔴 CI/CD pipeline will fail
• 🔴 All tests will fail

Required Fix: Either:

1. Revert variable name to resource_group_id (RECOMMENDED)
2. Update validation to reference var.resource_gRoup_id (NOT RECOMMENDED due to naming violation)

---

📋 Repository-Wide Context Checks

Documentation Updates Needed

• ❌ CHANGELOG.md - No entry for this change (required for breaking changes)
• ❌ Migration Guide - Not provided (required for breaking changes)
• ⚠️ Examples - Need verification that all examples are updated
• ⚠️ Tests - Need verification that all tests are updated

Test Coverage

• ⚠️ Test Updates - Tests likely reference resource_group_id and will fail
• ⚠️ Example Validation - Examples need to be tested with new variable name
• ⚠️ Validation Tests - Module validation will fail due to broken validation rule

Files That May Need Updates

If this change were to proceed (NOT RECOMMENDED), these files would need review:

• All files in examples/ directory
• All files in tests/ directory
• CHANGELOG.md
• Any documentation referencing resource_group_id

---

🎯 Top Recommendations

1. REVERT THIS CHANGE ⭐ (STRONGLY RECOMMENDED)

The variable name resource_gRoup_id appears to be a typo or intentional test of a bad update (as indicated by PR title "Do not merge: testing bad update").

Action: Revert to resource_group_id

2. If This Change Is Intentional (NOT RECOMMENDED)

This would require:

• Major version bump (e.g., 8.0.0 → 9.0.0)
• Complete CHANGELOG entry with BREAKING CHANGE section
• Migration guide for users
• Update all examples
• Update all tests
• Fix validation rule
• Justify why non-standard naming is needed (there is no valid justification)

3. Fix Validation Rule

Update the validation condition to reference the correct variable name, or revert the change.

4. Run Terraform Validate

terraform validate

This will fail with the current code.

5. Test Thoroughly

Run all tests and examples to ensure nothing breaks:

cd tests
go test -v -timeout 60m

---

📊 Overall Assessment

Code Quality: ❌ Poor - Contains critical naming violation and breaking change without documentation

Recommendation: ⛔ DO NOT MERGE

Reasoning:

1. Violates Terraform naming conventions (snake_case required)
2. Breaking change without proper documentation
3. Broken validation rule will cause immediate failures
4. Inconsistent with repository standards
5. PR title explicitly states "Do not merge: testing bad update"

This PR appears to be an intentional test of a problematic change, and the review correctly identifies it as unsuitable for merging.

---

✅ What Would Make This PR Acceptable?

Option A: Revert the Change (RECOMMENDED)

• Change variable name back to resource_group_id
• Update README.md to use resource_group_id
• No other changes needed

Option B: Proceed with Breaking Change (NOT RECOMMENDED)

• Use proper snake_case naming: resource_group_id (not resource_gRoup_id)
• Add CHANGELOG entry with BREAKING CHANGE
• Create migration guide
• Bump major version
• Update all examples and tests
• Fix validation rule

---

Review completed by Bob Reviewer 🤖
Automated infrastructure code review assistant

---

📚 References

• Terraform Style Guide
• Semantic Versioning
• TERRAFORM.md - Variable Management Best Practices
• REPOSITORY-CONSISTENCY.md - Naming Consistency Guidelines
• CHANGE-IMPACT.md - Breaking Changes Detection

[daniel-butler-irl]

Bob Reviewer - Automated Code Review Summary

Overview

Analyzed 2 files with changes to variable naming in the terraform-ibm-cos module.

Findings Summary

Total Issues Found: 6

By Category:

• Naming: 2 issues
• Best Practice: 1 issue
• Documentation: 1 issue
• Consistency: 1 issue
• Change Impact: 1 issue

By Severity:

• Blocking: 4 issues (must be fixed before merge)
• Warning: 2 issues (should be fixed)

---

Critical Issues (Blocking)

1. [Naming - Blocking] Variable Name Violates Terraform Naming Conventions

File: variables.tf (line 5)

The variable name resource_gRoup_id violates Terraform naming conventions by using mixed case (capital 'R' in the middle of "gRoup"). Terraform variables should use snake_case with all lowercase letters.

Reference: TERRAFORM.md - Section 4 (Variable Management)

• Variables should use snake_case naming convention
• Consistent naming improves code readability and maintainability

Impact: This makes the code harder to read and violates established Terraform best practices.

variable "resource_group_id" {

---

2. [Change Impact - Blocking] Breaking Change Without Migration Guide

Files: variables.tf, README.md

This change renames the resource_group_id variable to resource_gRoup_id, which is a breaking change that will break all existing consumers of this module.

Reference: CHANGE-IMPACT.md - Breaking Changes Detection

Required for breaking changes:

• CHANGELOG entry with "BREAKING CHANGE" label - MISSING
• Migration guide (MIGRATION.md or in README) - MISSING
• Major version bump (X.0.0) - NOT VERIFIED
• All examples updated - NOT VERIFIED
• All tests updated - NOT VERIFIED

Impact:

• All users currently using resource_group_id will experience immediate failures
• No migration path provided for users to update their configurations
• This will cause production outages if deployed

Required Actions:

1. Provide CHANGELOG entry documenting the breaking change
2. Create migration guide showing how to update from resource_group_id to new name
3. Update all examples in the repository
4. Update all tests to use new variable name
5. Bump major version number

---

3. [Consistency - Blocking] Variable Name Inconsistent with Repository Standards

File: variables.tf (line 5)

The new variable name resource_gRoup_id is inconsistent with the repository's existing naming patterns. All other variables in this module use lowercase snake_case (e.g., resource_keys, retention_default, retention_enabled).

Reference: REPOSITORY-CONSISTENCY.md - Naming Consistency

Impact: Creates inconsistency across the codebase, making it harder to maintain and understand.

Recommendation: Maintain the original resource_group_id naming to preserve consistency.

---

4. [Best Practice - Blocking] Appears to be Unintentional Typo

Files: variables.tf, README.md

The capitalization pattern gRoup (with capital 'R' in the middle) appears to be an unintentional typo rather than a deliberate naming choice. The PR title "Do not merge: testing bad update" confirms this is intentionally problematic code.

Impact: If merged, this would introduce a clear error into the codebase.

Recommendation: Revert this change and maintain resource_group_id.

---

Warnings

5. [Documentation - Warning] Missing Test Coverage Updates

Expected files to check: tests/pr_test.go, examples/*/main.tf

Reference: TEST-COVERAGE.md - Modified Modules

When module variables change, the following should be updated:

• All test files should use the new variable name
• All example configurations should be updated
• Tests should validate the variable still works correctly

Impact: If tests and examples aren't updated, they will fail when this change is deployed.

---

6. [Consistency - Warning] README Documentation Inconsistency

File: README.md (line 192)

The README table uses escaped underscores in the anchor link (resource\_gRoup\_id) which is inconsistent with standard Markdown anchor formatting.

Reference: MARKDOWN.md - Links and References

Recommendation: Ensure anchor links follow standard conventions.

---

Repository-Wide Context Checks

Documentation Context

• ❌ Breaking change not documented in CHANGELOG
• ❌ No migration guide provided
• ⚠️ Examples may need updates (not verified in this PR)

Test Coverage

• ⚠️ Tests not updated (not included in PR)
• ⚠️ Examples not updated (not included in PR)

Change Impact

• 🔴 HIGH IMPACT: This variable is likely used throughout the module
• 🔴 BREAKING: All module consumers will be affected
• 🔴 NO MIGRATION PATH: Users have no guidance on how to update

---

Top Recommendations

1. REVERT THIS CHANGE - The variable name change appears to be intentional test of a "bad update" (per PR title) and should not be merged
2. If this change is actually needed - Maintain resource_group_id naming to follow Terraform conventions
3. If renaming is required - Provide complete migration guide, update all examples and tests, and bump major version
4. Document breaking changes - Add CHANGELOG entry and migration instructions
5. Update all consumers - Ensure examples, tests, and documentation are synchronized

---

Overall Assessment

Status: ❌ BLOCKING ISSUES FOUND

This PR introduces a breaking change with incorrect naming conventions that violates Terraform best practices and repository consistency standards. The change lacks required documentation, migration guides, and test updates. Based on the PR title "Do not merge: testing bad update", this appears to be intentionally problematic code for testing purposes.

Recommendation: Do not merge this PR. If variable renaming is genuinely needed, it should:

1. Use proper snake_case naming (all lowercase)
2. Include complete migration documentation
3. Update all examples and tests
4. Follow semantic versioning with major version bump
5. Provide clear upgrade path for users

---

Review completed by Bob Reviewer - Automated Infrastructure Code Review Assistant
Analyzed against: TERRAFORM.md, MARKDOWN.md, DOCUMENTATION-CONTEXT.md, TEST-COVERAGE.md, REPOSITORY-CONSISTENCY.md, CHANGE-IMPACT.md

[daniel-butler-irl]

🤖 Bob Reviewer - Automated Code Review

Status: ❌ BLOCKING ISSUES FOUND

---

Issues Found (2 blocking)

📁 variables.tf - Line 5

[Naming - Blocking] Variable name uses mixed case (resource_gRoup_id) instead of snake_case. This violates Terraform naming conventions and breaks consistency across the module.

Suggested fix:

variable "resource_group_id" {

Impact: This is a breaking change that will affect all users of this module. Variable references in configurations will break.

---

📁 README.md - Line 192

[Breaking Change - Blocking] Variable name change is documented in README but missing required breaking change documentation:

• ❌ No CHANGELOG entry with "BREAKING CHANGE"
• ❌ No migration guide for users
• ❌ No major version bump documented
• ❌ Examples and tests not verified as updated

Required actions:

1. Add CHANGELOG entry documenting the breaking change
2. Provide migration instructions (or revert the breaking change)
3. Update all examples to use the new variable name
4. Update all tests to validate the change
5. Plan for major version bump (X.0.0)

---

Summary

Files reviewed: 2 | Lines changed: 4 | Review depth: Minimal (≤10 lines)

Key actions needed:

1. Revert the variable name change to resource_group_id (recommended)
2. OR document as breaking change with full migration guide
3. Ensure all module references are updated

Note: This appears to be a test PR ("Do not merge: testing bad update"). If this is intentional for testing purposes, these issues demonstrate what would be flagged in a real review.

[terraform-ibm-modules-ops]

🤖 Bob Reviewer - Status: ❌ BLOCKING

2 blocking issues found - see inline comments for details and suggested fixes.

Key actions needed:

• Fix variable name to use snake_case (resource_group_id)
• Revert breaking change or provide migration guide with major version bump

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	variable "resource_gRoup_id" {
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

[Breaking Change - Blocking] Variable renamed without migration guide or version bump. This is a breaking change requiring CHANGELOG entry, migration documentation, and major version bump.

Suggested change

	| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
	| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

🤖 Bob Reviewer - Status: ❌ BLOCKING

1 blocking issue found - see inline comments for details and suggested fixes.

Key actions needed:

• Fix variable naming to use snake_case (resource_group_id)
• Update README.md to match corrected variable name

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks all existing module usage.

Suggested change

	variable "resource_gRoup_id" {
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

[Consistency - Blocking] Variable name must match the corrected snake_case name in variables.tf.

Suggested change

	| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
	| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

Starting code review...

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency with the rest of the codebase.

Suggested change

	variable "resource_gRoup_id" {
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

[Documentation - Blocking] Variable name in documentation must match the corrected snake_case variable name.

Suggested change

	| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
	| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable name uses mixed case (gRoup) instead of snake_case on line 5 of variables.tf. This violates Terraform naming conventions and will break all references to this variable.

variable "resource_group_id" {

The same issue appears in README.md line 192 - both must be corrected to resource_group_id.

[terraform-ibm-modules-ops]

🤖 Bob Reviewer - Status: ❌ BLOCKING

1 blocking issue found - see comment above for details and suggested fix.

Key actions needed:

• Fix variable name from resource_gRoup_id to resource_group_id in both variables.tf and README.md

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

Review completed - blocking issues found that must be fixed before merge.

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	##############################################################################
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

| <a name="input_resource_keys"></a> [resource\_keys](#input\_resource\_keys) | The definition of the resource keys to generate. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_key). | <pre>list(object({<br/> name = string<br/> key_name = optional(string, null)<br/> generate_hmac_credentials = optional(bool, false)<br/> role = optional(string, "Reader")<br/> service_id_crn = optional(string, null)<br/> }))</pre> | `[]` | no |

| <a name="input_resource_group_id"></a> [resource\\_group\\_id](#input\\_resource\\_group\\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

🤖 Reviewer - Status: ✖️ BLOCKING

2 issues found - see inline comments below for details and suggested fixes.

Key actions needed:

• Fix variable naming in variables.tf
• Update README.md to match variable name changes

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
	| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	# Common variables
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

🤖 Reviewer - Status: ❌ BLOCKING

2 issues found - see inline comments below for details and suggested fixes.

Key actions needed:

• Update variable name to use snake_case in README.md
• Update variable name to use snake_case in variables.tf

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
	| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	# Common variables
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

🤖 Reviewer - Status: ⚠️ COMMENTS

2 issues found - see inline comments below for details and suggested fixes.

Key actions needed:

• Update variable names to use snake_case
• Verify README documentation matches variable changes

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
	| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	# Common variables
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

🤖 Reviewer - Status: ⚠️ COMMENTS

2 issues found - see inline comments below for details and suggested fixes.

Key actions needed:

• Update variable names to use snake_case
• Verify README documentation matches variable changes

Files reviewed: 2 | Lines changed: 4

[terraform-ibm-modules-ops]

🤖 Reviewer - This commit has already been reviewed. Please see previous comments for feedback.

[terraform-ibm-modules-ops]

Review in progress...

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
	| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	# Common variables
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

🤖 Reviewer - This commit has already been reviewed.

Please see previous review comments for feedback. If you've pushed new changes, the new commit will be reviewed automatically.

[terraform-ibm-modules-ops]

Please review the changes made in this pull request.

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

See summary comment above for review overview.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change

	##############################################################################
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case in documentation. This violates Terraform conventions and breaks consistency.

Suggested change

	| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
	| <a name="input_resource_group_id"></a> [resource\\_group\\_id](#input\\_resource\\_group\\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[terraform-ibm-modules-ops]

🤖 Reviewer - Review in progress...

[terraform-ibm-modules-ops]

Automated code review completed. See inline comments for details.

[terraform-ibm-modules-ops]

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform naming conventions and breaks consistency with the rest of the codebase.

Suggested change

	variable "resource_gRoup_id" {
	variable "resource_group_id" {

[terraform-ibm-modules-ops]

[Documentation - Blocking] Documentation updated to match incorrect variable name. Variable name must use snake_case per Terraform conventions.

Suggested change

	| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
	| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

[daniel-butler-irl]

/bob review

[daniel-butler-irl]

/bob review

[daniel-butler-irl]

/bob review

[daniel-butler-irl]

/bob review

[terraform-ibm-modules-ops]

🤖 Bob Reviewer - This commit has already been reviewed. Please see previous comments for feedback.