feat(backup): add GKE backup configuration in the module #2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameausoone
force-pushed
the
feat/backup-plan
branch
from
0c8e37a to
98f63dc
Compare
Introduce new variables for GKE backup configuration, including `backup_cron_schedule`, `backup_rpo_target_in_minutes`, `backup_config`, and `backup_retain_days`. These new settings enable backup schedule definition, RPO configuration, volume data and secrets backup options, and backup retention period definition.
Ameausoone
force-pushed
the
feat/backup-plan
branch
from
98f63dc to
acb8692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces new configuration variables for managing GKE backups:
backup_cron_schedule: Define backup scheduling as per a cron expression.backup_rpo_target_in_minutes: Configure the Recovery Point Objective (RPO).backup_config: Specify which volumes or secrets to back up.backup_retain_days: Set the retention period for backups.google_gke_backup_backup_planto enable backupCloses #2259
Checklist
No tests added, but I tested this PR manually, tests seems to not be designed to check other resources than the GKE cluster.
By the way
Integration tests are designed from the ground to be executed in a organisation (which is totally relevant), but it could be difficult (even for professional) to get project creation rights in an organisation. It would be handy to have at least a procedure to execute the tests, in a regular project.